Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Don't mention the Symfony Standard edition in the contributing docs#11712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:4.2fromjaviereguiluz:fix_11692
Jun 11, 2019
Merged
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletionscontributing/community/reviews.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,16 +58,16 @@ The steps for the review are:

#. **Is the Report Complete?**

Good bug reports contain a link to afork ofthe`Symfony Standard Edition`_
(the "reproduction project") that reproducesthebug. If it doesn't, the
report should at least contain enough information and code samples to
reproduce the bug.
Good bug reports contain a link to aproject (the"reproduction project")
created with the `Symfony skeleton`_ orthe`Symfony website skeleton`_
that reproduces the bug. If it doesn't, the report should at least contain
enough information and code samples toreproduce the bug.

#. **Reproduce the Bug**

Download the reproduction project and test whether the bug can be reproduced
on your system. If the reporter did not provide a reproduction project,
create oneby forking_the `SymfonyStandard Edition`_.
create onebased on one `Symfony skeleton`_ (orthe `Symfonywebsite skeleton`_).

#. **Update the Issue Status**

Expand DownExpand Up@@ -96,7 +96,7 @@ The steps for the review are:

Thank you @weaverryan for creating this bug report! This indeed looks
like a bug. I reproduced the bug in the "kernel-bug" branch of
https://github.com/webmozart/symfony-standard.
https://github.com/webmozart/some-project.

Status: Reviewed

Expand DownExpand Up@@ -134,9 +134,9 @@ Pick a pull request from the `PRs in need of review`_ and follow these steps:
#. **Reproduce the Problem**

Read the issue that the pull request is supposed to fix. Reproduce the
problem on aclean`SymfonyStandard Edition`_project and try to understand
why it exists. If the linked issue already contains such a project, install
it and run it on your system.
problem on anew project created with the`Symfonyskeleton`_(or the
`Symfony website skeleton`_) and try to understand why it exists. If the
linked issue already contains such a project, installit and run it on your system.

#. **Review the Code**

Expand DownExpand Up@@ -211,7 +211,8 @@ Pick a pull request from the `PRs in need of review`_ and follow these steps:

.. _GitHub: https://github.com
.. _Symfony issue tracker: https://github.com/symfony/symfony/issues
.. _Symfony Standard Edition: https://github.com/symfony/symfony-standard
.. _`Symfony skeleton`: https://github.com/symfony/skeleton
.. _`Symfony website skeleton`: https://github.com/symfony/website-skeleton
.. _create a GitHub account: https://help.github.com/articles/signing-up-for-a-new-github-account/
.. _forking: https://help.github.com/articles/fork-a-repo/
.. _bug reports in need of review: https://github.com/symfony/symfony/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22Bug%22+label%3A%22Status%3A+Needs+Review%22+
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp