Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Don't mention the Symfony Standard edition in the contributing docs#11712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:4.2fromjaviereguiluz:fix_11692
Jun 11, 2019

Conversation

@javiereguiluz
Copy link
Member

Fixes#11692.

Copy link

@boiteboite left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 but change to links a couple more mentions of the skeletons

@javiereguiluz
Copy link
MemberAuthor

We usually only show the link the first time something is included in the article ... but these "skeletons" are still not well-known by lots of people, so let's include the links always. Thanks.

Copy link

@boiteboite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Whoops! Sorry for making you do more work; one more change for the sake of consistency. I've read through the document in full this time. Looks great! Thank you@javiereguiluz.

@javiereguiluzjaviereguiluz merged commitf5f339c intosymfony:4.2Jun 11, 2019
javiereguiluz added a commit that referenced this pull requestJun 11, 2019
…buting docs (javiereguiluz)This PR was squashed before being merged into the 4.2 branch (closes#11712).Discussion----------Don't mention the Symfony Standard edition in the contributing docsFixes#11692.Commits-------f5f339c Don't mention the Symfony Standard edition in the contributing docs
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@boiteboiteboite approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

3 participants

@javiereguiluz@boite@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp