Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Lock] mongodb store removed from symfony 4.3#11686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@kralos I wasn't aware of this. Thanks for taking care of updating it. |
javiereguiluz added a commit that referenced this pull requestJun 12, 2019
This PR was merged into the 4.3 branch.Discussion----------[Lock] mongodb store removed from symfony 4.3MongoDbStore wasn't actually added in symfony 4.3, it will be added in 4.4.Seesymfony/symfony#31889Commits-------75ad033 #27345 Removed Lock MongoDbStore, it will be added in symfony 4.4
fabpot added a commit to symfony/symfony that referenced this pull requestDec 11, 2019
This PR was submitted for the 4.4 branch but it was squashed and merged into the 5.1-dev branch instead (closes#31889).Discussion----------[Lock] add mongodb store| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes (requires `ext-mongodb` and `mongodb/mongodb` to test)| Fixed tickets |#27345| License | MIT| Original Doc PR |symfony/symfony-docs#9807| Remove from 4.3 Doc PR |symfony/symfony-docs#11686| Add to 4.4 Doc PR |symfony/symfony-docs#11735Looks like I messed up `kralos:27345-lock-mongodb` with a force push (trying to fix ci issues) right before it was merged to `master` (`4.3.0`).see#27648**Description**We should support Semaphore Locks with a MongoDB back end to allow those that already use MongoDB as a distributed storage engine.Symfony already partially supports MongoDB for session storage: `Symfony\Component\HttpFoundation\Session\Storage\Handler\MongoDbSessionHandler`**Example**```php$client = new MongoDb\Client();$store = new Symfony\Component\Lock\Store\MongoDbStore( $client array( 'database' => 'my-app', ));$lockFactory = new Symfony\Component\Lock\Factory($store);$lock = $lockFactory->createLock('my-resource');```Commits-------a6bfa59 [Lock] add mongodb store
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MongoDbStore wasn't actually added in symfony 4.3, it will be added in 4.4.
Seesymfony/symfony#31889