Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[DependencyInjection] Added optionignore_errors: not_found for imported config files#11647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ignore_not_found option.ignore_errors: not_found for imported config filesMember
nicolas-grekas commentedNov 7, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Should be reviewed after the changes done tosymfony/symfony#31310 |
db7c598 tof6de406Comparenicolas-grekas added a commit to symfony/symfony that referenced this pull requestNov 8, 2019
…_found` for imported config files (pulzarraider)This PR was merged into the 4.4 branch.Discussion----------[DependencyInjection] Added option `ignore_errors: not_found` for imported config files| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#11647If someone want to add optional config file. The only available choice was to add `ignore_errors: true` optione.g.```imports: - { resource: parameters.yml, ignore_errors: true }```But this will hide all errors in imported file. We ran in many situations that broke our Symfony applications because we had a typo in this imported files.This PR introduce new possible value `not_found` for `ignore_errors` option. It can be used for optional config files like the `ignore_errors: true`, but it will ignore only the file non-existence, not the possible syntax errors inside.Usage:```imports: - { resource: parameters.yml, ignore_errors: not_found}```Commits-------e0ee01c [DependencyInjection] Added option `ignore_errors: not_found` while importing config files
symfony-splitter pushed a commit to symfony/dependency-injection that referenced this pull requestNov 8, 2019
…_found` for imported config files (pulzarraider)This PR was merged into the 4.4 branch.Discussion----------[DependencyInjection] Added option `ignore_errors: not_found` for imported config files| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#11647If someone want to add optional config file. The only available choice was to add `ignore_errors: true` optione.g.```imports: - { resource: parameters.yml, ignore_errors: true }```But this will hide all errors in imported file. We ran in many situations that broke our Symfony applications because we had a typo in this imported files.This PR introduce new possible value `not_found` for `ignore_errors` option. It can be used for optional config files like the `ignore_errors: true`, but it will ignore only the file non-existence, not the possible syntax errors inside.Usage:```imports: - { resource: parameters.yml, ignore_errors: not_found}```Commits-------e0ee01c10d [DependencyInjection] Added option `ignore_errors: not_found` while importing config files
symfony-splitter pushed a commit to symfony/config that referenced this pull requestNov 8, 2019
…_found` for imported config files (pulzarraider)This PR was merged into the 4.4 branch.Discussion----------[DependencyInjection] Added option `ignore_errors: not_found` for imported config files| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#11647If someone want to add optional config file. The only available choice was to add `ignore_errors: true` optione.g.```imports: - { resource: parameters.yml, ignore_errors: true }```But this will hide all errors in imported file. We ran in many situations that broke our Symfony applications because we had a typo in this imported files.This PR introduce new possible value `not_found` for `ignore_errors` option. It can be used for optional config files like the `ignore_errors: true`, but it will ignore only the file non-existence, not the possible syntax errors inside.Usage:```imports: - { resource: parameters.yml, ignore_errors: not_found}```Commits-------e0ee01c10d [DependencyInjection] Added option `ignore_errors: not_found` while importing config files
wouterj approved these changesOct 3, 2020
maxhelias approved these changesOct 4, 2020
f6de406 to0a6873dCompareMember
wouterj commentedOct 4, 2020
Thanks@pulzarraider! During the merge, I've slightly modified the comments to make them a bit shorter (to avoid horizontal scrolling). |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Related merge request:symfony/symfony#31310