Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Removed Symfony 4.* versionadded directives#11620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
OskarStark approved these changesMay 29, 2019
Contributor
OskarStark left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
❤️ 👏
MemberAuthor
javiereguiluz commentedMay 29, 2019
At this moment I'm preparing another PR against master to remove all the deprecated stuff, which is different from this. |
javiereguiluz added a commit that referenced this pull requestMay 30, 2019
This PR was merged into the master branch.Discussion----------Removed Symfony 4.* versionadded directives"Master" branch will become Symfony 5.0, so we can remove all this.Commits-------bcc55c5 Removed Symfony 4.* versionadded directives
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestMay 31, 2019
This PR was squashed before being merged into the master branch (closessymfony#11621).Discussion----------Removed deprecated contentsThis is related tosymfony#11620 and removes deprecated things.The only remaining deprecation is the `transChoice()` method. I'm leaving that for future PRs because@wouterj created a big PR pending to be merged related to that.Commits-------ce64ac2 Removed deprecated contents
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Master" branch will become Symfony 5.0, so we can remove all this.