Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Tweaks for DispatchAfterCurrentBusMiddleware entry#11597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@weaverryan
Copy link
Member

Just some proofreading changes for#10015!

single: Messenger; Record messages; Transaction messages

Transactional Messages: HandleEventsAfterCommandHandler is Done
Transactional Messages: HandleNew MessagesAfterHandling is Done
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's a bit tricky: in Messenger, messages are called messages. If you're using Messenger as an event bus, you can of course call them events. I'm mostly using the word "message" to keep consistent with messenger (and not confuse with the EventDispatcher), though I keep "event" wording in the code examples.

OskarStark reacted with thumbs up emoji
],
],
]);
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This code block didn't seem relevant anymore. I think it originally came from whendispatch_after_current_bus was not going to be included as a default middleware, so you needed to show how it was added to config.

will be wrapped into a ``DelayedMessageHandlingException``. Using ``DelayedMessageHandlingException::getExceptions``
will give you all exceptions that are thrown while handing a message with the ``DispatchAfterCurrentBusStamp``.

The ``dispatch_after_current_bus`` middleware is enabled by default. If you're
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

2 spaces after “The”

@javiereguiluz
Copy link
Member

Thanks Ryan.

javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestMay 28, 2019
…dleware entry (weaverryan)This PR was merged into the 4.3 branch.Discussion----------[Messenger] Tweaks for DispatchAfterCurrentBusMiddleware entryJust some proofreading changes forsymfony#10015!Commits-------599d10b minor reorg of new DispatchAfterCurrentBusMiddleware
@javiereguiluzjaviereguiluz merged commit599d10b intosymfony:4.3May 28, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@weaverryan@javiereguiluz@OskarStark@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp