Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Messenger] Tweaks for DispatchAfterCurrentBusMiddleware entry#11597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| single: Messenger; Record messages; Transaction messages | ||
| Transactional Messages: HandleEventsAfterCommandHandler is Done | ||
| Transactional Messages: HandleNew MessagesAfterHandling is Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's a bit tricky: in Messenger, messages are called messages. If you're using Messenger as an event bus, you can of course call them events. I'm mostly using the word "message" to keep consistent with messenger (and not confuse with the EventDispatcher), though I keep "event" wording in the code examples.
| ], | ||
| ], | ||
| ]); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This code block didn't seem relevant anymore. I think it originally came from whendispatch_after_current_bus was not going to be included as a default middleware, so you needed to show how it was added to config.
| will be wrapped into a ``DelayedMessageHandlingException``. Using ``DelayedMessageHandlingException::getExceptions`` | ||
| will give you all exceptions that are thrown while handing a message with the ``DispatchAfterCurrentBusStamp``. | ||
| The ``dispatch_after_current_bus`` middleware is enabled by default. If you're |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
2 spaces after “The”
javiereguiluz commentedMay 28, 2019
Thanks Ryan. |
…dleware entry (weaverryan)This PR was merged into the 4.3 branch.Discussion----------[Messenger] Tweaks for DispatchAfterCurrentBusMiddleware entryJust some proofreading changes forsymfony#10015!Commits-------599d10b minor reorg of new DispatchAfterCurrentBusMiddleware
Just some proofreading changes for#10015!