Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Remove short factories/configurators examples#11589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
symfony-splitter pushed a commit to symfony/dependency-injection that referenced this pull requestMay 22, 2019
This PR was merged into the 4.4-dev branch.Discussion----------[DI] deprecate short callables in yaml| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#11589This deprecates defining factories as `foo:method` instead of `['@foo', 'method']` in yaml.This is confusing syntax and misses the opportunity to raise an error when one does a typo and uses a single colon instead of two.This basically reverts #19190Commits-------f8a04fdda6 [DI] deprecate short callables in yaml
nicolas-grekas added a commit to symfony/symfony that referenced this pull requestMay 22, 2019
This PR was merged into the 4.4-dev branch.Discussion----------[DI] deprecate short callables in yaml| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#11589This deprecates defining factories as `foo:method` instead of `['@foo', 'method']` in yaml.This is confusing syntax and misses the opportunity to raise an error when one does a typo and uses a single colon instead of two.This basically reverts#19190Commits-------f8a04fd [DI] deprecate short callables in yaml
Member
javiereguiluz commentedMay 29, 2019
Thank you! |
javiereguiluz added a commit that referenced this pull requestMay 29, 2019
…rekas)This PR was merged into the 4.2 branch.Discussion----------Remove short factories/configurators examplesThis PR reverts#7203, as short factories are more confusing than useful.I'm proposing to deprecate them insymfony/symfony#31543Note that some of this patch can (should) be adapted to 3.4 also.Commits-------e8cfa6e Remove short factories/configurators examples
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts#7203, as short factories are more confusing than useful.
I'm proposing to deprecate them insymfony/symfony#31543
Note that some of this patch can (should) be adapted to 3.4 also.