Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] config doc#11580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@noniagriconomie
Copy link
Contributor

@noniagriconomienoniagriconomie commentedMay 16, 2019•
edited by OskarStark
Loading

Hi,

This draft PR follows this one
https://github.com/symfony/symfony-docs/pull/11492/files (config for 3.X version)
but for new version, mostly 4.3

I checked this PR also
symfony/symfony#30890,@lyrixx review appreciated please

Maybe to merge after merging#11578, and with a rebase ?

Draft for now

this one can be closed also:

alexislefebvre reacted with thumbs up emoji
@OskarStark
Copy link
Contributor

#11578 is merged, you can now rebase your branch 😃

noniagriconomie reacted with thumbs up emoji

@noniagriconomienoniagriconomie marked this pull request as ready for reviewMay 17, 2019 15:53
<framework:support>App\Entity\BlogPost</framework:support>
<framework:initial_marking>draft</framework:initial_marking>
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@OskarStark really unsure of the pattern, I never use xml :/
Also i remove spaces like php and yml docbloc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am unsure too about the xml config

cc@lyrixx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

friendly ping@lyrixx can you please give us some feedback here?

@noniagriconomie
Copy link
ContributorAuthor

@OskarStark friendly ping, do i need to do other thing? thx

@noniagriconomienoniagriconomie deleted the feature-workflow-config branchJune 25, 2019 15:14
@lyrixx
Copy link
Member

Hello@noniagriconomie
Why did you close your PR?

@noniagriconomienoniagriconomie restored the feature-workflow-config branchJune 26, 2019 07:43
@noniagriconomie
Copy link
ContributorAuthor

noniagriconomie commentedJun 26, 2019•
edited
Loading

@lyrixx fail branch removal, thank for noticing :)

I was cleaning my sf doc fork :/

OskarStark reacted with confused emoji

@OskarStark
Copy link
Contributor

Argh wrong button

@OskarStark
Copy link
Contributor

@noniagriconomie can you please rebase your branch? Afterwards we are good to go 👍

@noniagriconomie
Copy link
ContributorAuthor

@OskarStark will do it asap, but i fear i will be afk soon ofr a short period of time :/
will do my best :)

OskarStark reacted with heart emoji

@noniagriconomie
Copy link
ContributorAuthor

@OskarStark PR is ok for me

*:ref:`name<reference-workflows-name>`

* `audit_trail`_
* `initial_place`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@javiereguiluz is it ok to remove the deprecated one here? Or do we need to leave some info about the before option name?

@wouterj
Copy link
Member

Soo as you can see I completely destroyed your branch here. Fortunately, GitHub keeps all commit refs in your fork, so I was able to correctly rescue all your amazing changes and created a new PR:#12146

I've also checked the XML code and it looks perfect. One minor thing: While both underscore and dash are valid in Symfony configuration, using the dash is considered better XML, so I've directly updated the one occurence of underscore.

Also, it appeared that the dumping article was already rewritten during the opening of this PR and now. So I've removed that from the changes.

Thanks a lot and sorry for our slow responses on this PR.

wouterj added a commit that referenced this pull requestAug 12, 2019
This PR was merged into the 4.3 branch.Discussion----------[4.3] Update workflow configRescued some really bad git stuff from me while merging:#11580Original description:> Hi,>> This draft PR follows this one>https://github.com/symfony/symfony-docs/pull/11492/files (config for 3.X version)> but for new version, mostly 4.3>> I checked this PR also>symfony/symfony#30890,@lyrixx review appreciated please>> Maybe to merge after merging#11578, and with a rebase ?>> -------------------->> Draft for now>> -Closes#11229>> this one can be closed also:>> -Closes#9475> -Closes#10197Commits-------fdc221b Minor XML improvementa640d14 [Workflow] config doc7bb2041 Fix indentf65f1bc Reviewcf3a32c Doc config metadata34e7cc5 [Workflow] config doc
@noniagriconomie
Copy link
ContributorAuthor

@wouterj thank you

@noniagriconomienoniagriconomie deleted the feature-workflow-config branchAugust 13, 2019 07:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

+1 more reviewer

@lyrixxlyrixxlyrixx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@noniagriconomie@OskarStark@lyrixx@wouterj@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp