Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] doc improvements#11578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@noniagriconomie
Copy link
Contributor

Hi,

Here are some workflow doc improvements:

  • keep as much as possible in synch the subject, places and transition in the related docs
  • change "travis" in favor of "test" (travis may not be known) + update image
  • move transition blocker via listener part into the right sub part + rewrite it

Thanks

@noniagriconomienoniagriconomie changed the titleWorkflow doc[Workflow] doc improvementsMay 16, 2019
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

With some minor comments 👍

Thank you for working out the details and making this part of the docs consistent 🎉

# run this command if you prefer SVG images:
# $ php dump-graph-dot.php | dot -Tsvg -o dot_graph.svg
$ php dump-graph-puml.php | java -jar plantuml.jar -p > puml_graph.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this grouping is a bit confusing now, because it generates apng file, but follows a comment/description which is talking aboutsvg 🤔

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

wanted to "group"dot cli vsjava
i propose a new way

$ php bin/console workflow:dump workflow_name | dot -Tpng -o workflow_name.png
# run this command if you prefer SVG images:
# $ php bin/console workflow:dump workflow_name | dot -Tsvg -o workflow_name.svg
$ php bin/console workflow:dump workflow_name --dump-format=puml | java -jar plantuml.jar -p > workflow_name.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

same as above

@noniagriconomie
Copy link
ContributorAuthor

@OskarStark review/rework addressed
still unsure of the "dumping" part

@javiereguiluzjaviereguiluz added this to the4.2 milestoneMay 16, 2019
@javiereguiluz
Copy link
Member

Note to mergers: merge in 4.2 branch.

@OskarStarkOskarStark changed the base branch frommaster to4.2May 17, 2019 06:46
@OskarStark
Copy link
Contributor

OskarStark commentedMay 17, 2019•
edited
Loading

Thank you Antoine, I merged it in4.2 👍

@OskarStarkOskarStark merged commitd6b8d18 intosymfony:4.2May 17, 2019
OskarStark added a commit that referenced this pull requestMay 17, 2019
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes#11578).Discussion----------[Workflow] doc improvementsHi,Here are some workflow doc improvements:- keep as much as possible in synch the subject, places and transition in the related docs- change "travis" in favor of "test" (travis may not be known) + update image- move transition blocker via listener part into the right sub part + rewrite itThanksCommits-------d6b8d18 Workflow doc
@noniagriconomienoniagriconomie deleted the feature-workflow-doc branchMay 17, 2019 07:39
wouterj added a commit that referenced this pull requestAug 12, 2019
This PR was merged into the 4.3 branch.Discussion----------[4.3] Update workflow configRescued some really bad git stuff from me while merging:#11580Original description:> Hi,>> This draft PR follows this one>https://github.com/symfony/symfony-docs/pull/11492/files (config for 3.X version)> but for new version, mostly 4.3>> I checked this PR also>symfony/symfony#30890,@lyrixx review appreciated please>> Maybe to merge after merging#11578, and with a rebase ?>> -------------------->> Draft for now>> -Closes#11229>> this one can be closed also:>> -Closes#9475> -Closes#10197Commits-------fdc221b Minor XML improvementa640d14 [Workflow] config doc7bb2041 Fix indentf65f1bc Reviewcf3a32c Doc config metadata34e7cc5 [Workflow] config doc
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@noniagriconomie@javiereguiluz@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp