Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[HttpFoundation] Add documentation about the session.#1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
components/http_foundation.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
misingthat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not necessary here since this is a direct statement of what native handlers are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So-called 'native' handlers are session handlers are
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed
ghost commentedMar 14, 2012
@stof - thanks for the great feedback. This should be good to go now. |
components/http_foundation.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missing either:: at the end of the previous paragraph or.. code-block:: php to make it a code block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed.
ghost commentedMar 14, 2012
All corrections have been made, thanks! |
ghost commentedMar 15, 2012
This is ready for merge - I may expand the documentation in a second PR later, but for now this is a start :-) |
ghost commentedMar 18, 2012
@weaverryan@fabpot is there anything pending for this PR to be merged? |
weaverryan commentedMar 18, 2012
Hey Drak! I'll take a look at this today and merge it in. Thanks! |
[HttpFoundation] Add documentation about the session.
weaverryan commentedMar 19, 2012
Really really nice Drak! This is probably the most thoroughly-documented component section we have yet. I made some minor tweaks in sha:679374b Thanks! |
ghost commentedMar 19, 2012
We need to find someone who can document the Security component. I am not familiar enough with it. |
weaverryan commentedMar 19, 2012
Haha, yes we do - I think that component will likely be several pieces instead of just one document. I know enough about it, just a matter of finding the time. |
Refssymfony/symfony#3493 and willclose#1135