Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Workflow configuration#11492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@noniagriconomie
Copy link
Contributor

@noniagriconomienoniagriconomie commentedApr 25, 2019•
edited
Loading

Hi,

Related to#11043
I can also provide the 4.3 update (when 4.3 is feature freezed ? should we do 4.1/4.2 ?)

The review can be difficult as I reordered some parts, better read it on the SymfonyCloud build

Cheers

@noniagriconomie
Copy link
ContributorAuthor

friendly ping@lyrixx as codeowner of workflow, reviews/comments appreciated :)

@javiereguiluz
Copy link
Member

@noniagriconomie thanks for working on this! Sadly, we cannot reorder the options as proposed. We should keep the alphabetical sorting, which is what we use in all listings of config options across the docs.

@noniagriconomie
Copy link
ContributorAuthor

noniagriconomie commentedApr 25, 2019•
edited
Loading

@javiereguiluz ha ok, understood, i reordered them as "config priority"
I will revert no problem

edit : reverted@javiereguiluz

@noniagriconomienoniagriconomieforce-pushed thefeature-workflow-config branch 3 times, most recently fromac87421 toeb7a4fcCompareApril 26, 2019 08:08
Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@noniagriconomie
Copy link
ContributorAuthor

noniagriconomie commentedMay 5, 2019•
edited
Loading

@OskarStark I am currently in vacations
Feel free to commit your suggestions and advance the PR 👍🏻
Edit : I will do the 4.3 version when this is merged
Thanks

@OskarStark
Copy link
Contributor

Feel free to commit your suggestions and advance the PR 👍🏻

Enjoy your vacation 🌴 ☀️ , we can apply the changes when merging this PR!

👍 from my side@javiereguiluz

noniagriconomie reacted with thumbs up emoji

@javiereguiluzjaviereguiluz merged commit6282e97 intosymfony:3.4May 6, 2019
javiereguiluz added a commit that referenced this pull requestMay 6, 2019
This PR was merged into the 3.4 branch.Discussion----------Workflow configurationHi,Related to#11043I can also provide the 4.3 update (when 4.3 is feature freezed ? should we do 4.1/4.2 ?)The review can be difficult as I reordered some parts, better read it on the SymfonyCloud buildCheersCommits-------6282e97 Workflow configuration
@javiereguiluz
Copy link
Member

Thanks Antoine! We merged this and made all changes proposed by@OskarStark while merging it.

OskarStark and noniagriconomie reacted with thumbs up emoji

@noniagriconomienoniagriconomie deleted the feature-workflow-config branchMay 16, 2019 16:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@OskarStarkOskarStarkOskarStark approved these changes

+1 more reviewer

@lyrixxlyrixxlyrixx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@noniagriconomie@javiereguiluz@OskarStark@lyrixx@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp