Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Add flock:// option to framework lock configuration reference#11466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
javiereguiluz merged 1 commit intosymfony:4.3fromHypeMC:extend-framework-lock-configuration-reference-4.2Sep 26, 2019
Merged
Add flock:// option to framework lock configuration reference#11466
javiereguiluz merged 1 commit intosymfony:4.3fromHypeMC:extend-framework-lock-configuration-reference-4.2Sep 26, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedApr 22, 2019
javiereguiluz added a commit that referenced this pull requestSep 26, 2019
This PR was merged into the 3.4 branch.Discussion----------Extend framework lock configuration referenceFixes#9779.This extends the documentation for the framework bundle lock integration which was add withsymfony/symfony@e5ddd14 .The only current documentation is a blog post:https://symfony.com/blog/new-in-symfony-3-3-lock-component .**NOTE 1**: The xml configuration doesn't currently work, seesymfony/symfony#31197**NOTE 2**: There is an additional PR for the `flock://` option which was added in Symofny 4.2, see#11466Commits-------d0161b4 Extend framework lock configuration reference
javiereguiluz added a commit that referenced this pull requestSep 26, 2019
…rence (HypeMC)This PR was submitted for the 4.2 branch but it was squashed and merged into the 4.3 branch instead (closes#11466).Discussion----------Add flock:// option to framework lock configuration referenceFixes#9779 & extends#11465 .Documents the `flock://` option which was added withsymfony/symfony#26923 .**NOTE 1**: The xml configuration doesn't currently work, seesymfony/symfony#31197**NOTE 2**: This PR has all the changes that#11465 has plus some symfony 4.2 specific additions, so#11465 should probably be merged first.Commits-------d9125fd Add flock:// option to framework lock configuration reference
Member
javiereguiluz commentedSep 26, 2019
I apologize here too for the long delay to merge this. Thanks for your contribution! |
nicolas-grekas added a commit to symfony/symfony that referenced this pull requestSep 26, 2019
…not working as expected (HypeMC)This PR was squashed before being merged into the 3.4 branch (closes#31198).Discussion----------[FrameworkBundle] Fix framework bundle lock configuration not working as expected| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#31197| License | MIT| Doc PR |symfony/symfony-docs#11465 &symfony/symfony-docs#11466Thisfixes#31197 and makes the lock configuration work with installations that are not full stack ones and configurations that use xml files.Commits-------c7af2df [FrameworkBundle] Fix framework bundle lock configuration not working as expected
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestSep 26, 2019
…not working as expected (HypeMC)This PR was squashed before being merged into the 3.4 branch (closes #31198).Discussion----------[FrameworkBundle] Fix framework bundle lock configuration not working as expected| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #31197| License | MIT| Doc PR |symfony/symfony-docs#11465 &symfony/symfony-docs#11466This fixes #31197 and makes the lock configuration work with installations that are not full stack ones and configurations that use xml files.Commits-------c7af2df340 [FrameworkBundle] Fix framework bundle lock configuration not working as expected
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#9779 & extends#11465 .
Documents the
flock://option which was added withsymfony/symfony#26923 .NOTE 1: The xml configuration doesn't currently work, seesymfony/symfony#31197
NOTE 2: This PR has all the changes that#11465 has plus some symfony 4.2 specific additions, so#11465 should probably be merged first.