Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
feature: move hinclude from template to fragments#11461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
javiereguiluz merged 1 commit intosymfony:masterfromSimperfit:feature/move-hinclude-from-template-to-fragmentsApr 23, 2019
Merged
feature: move hinclude from template to fragments#11461
javiereguiluz merged 1 commit intosymfony:masterfromSimperfit:feature/move-hinclude-from-template-to-fragmentsApr 23, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
OskarStark commentedApr 22, 2019
Could you please add a link to the corresponding code PR? |
ContributorAuthor
Simperfit commentedApr 22, 2019 via email• edited by OskarStark
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by OskarStark
Uh oh!
There was an error while loading.Please reload this page.
The PR link issymfony/symfony#30959 I will update the header whenI’m back at home. |
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestApr 23, 2019
… (Simperfit)This PR was merged into the master branch.Discussion----------feature: move hinclude from template to fragments<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/roadmap for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `master` for features of unreleased versions).-->This is linked to the recent changes on hinclude which has been moved from Templating to FragmentsCommits-------d625ac5 feature: move hinclude from template to fragments
Member
javiereguiluz commentedApr 23, 2019
Thanks Hamza! |
Contributor
OskarStark commentedApr 23, 2019
I added the link to the PR header for you 😊 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is linked to the recent changes on hinclude which has been moved from Templating to Fragments
Refssymfony/symfony#30959