Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Encore: add guide to use Encore in a virtual machine#11422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…a VMEven with the current doc, some people were not able to make it works in a VM, seesymfony/webpack-encore#277.
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice! This was always a bit obscure and I'm glad that some Encore expert is contributing new docs for it. Thanks.
Uh oh!
There was an error while loading.Please reload this page.
| Encore.configureWatchOptions(watchOptions => { | ||
| watchOptions.poll = 250; // check for changes every 250 ms | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe also add a note here about the CLI equivalent (--watch-poll)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yep why not, but it means that the user will have to pass--watch-poll two times in itspackage.json 😕
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Kocal commentedApr 15, 2019
Thanks@javiereguiluz and@Lyrkan, reviews have been applied :) |
javiereguiluz commentedApr 25, 2019
Hugo, thanks as always for contributing these docs. We made some minor rewords while merging ... but we maintained most of your original work. |
Kocal commentedApr 25, 2019
Don't worry and thanks for the rewords. Next time will be better! :) |
Hi, ✋
As the title says, this PR add a new guide for using Encore in a virtual machine.
This is what we use on ours Symfony apps at work which run inside a Vagrant VM.
It works really fine and I thought it would be helpful to share it with other people.
Also, I've removed a sub-section in the actual doc because according tosymfony/webpack-encore#277, it was not working because some additional configuration was missing (and I can confirm it because I'm one of his co-worker 😛).