Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] Guard documentation#11421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@noniagriconomie
Copy link
Contributor

Hi,

Here is a draft PR for this issue#11214

@pbowyer@xabbuh@javiereguiluz Am I in the right direction?

Thank you,

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks Antoine! It looks nice so far, but I'm not expert in Workflow, so we'll need more reviews.

Copy link
Contributor

@pbowyerpbowyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for writing this! It is a great beginning; my changes are to do with the English rather than the technical side of using Workflow Guards. More rewording will be needed, but let's get the content approved first.

@noniagriconomienoniagriconomie marked this pull request as ready for reviewApril 15, 2019 05:20
@noniagriconomie
Copy link
ContributorAuthor

@pbowyer@javiereguiluz review addressed

For the "technical side content" you mentioned, do you see any other workflow guard feature needed to document here?

@pbowyer
Copy link
Contributor

@noniagriconomie I'm learning Workflow as I go, so I'm not the best person to give a technical review. Pinging@lyrixx and@HeahDude who know a lot!

@lyrixx
Copy link
Member

Hello,

Thanks for your PR.
Guard are supported by the workflow from day 1. So could tou rebase your branch on the lowest supported branch: 3.4?

@noniagriconomienoniagriconomie changed the base branch frommaster to3.4April 15, 2019 13:07
@noniagriconomienoniagriconomie changed the base branch from3.4 tomasterApril 15, 2019 13:07
@noniagriconomie
Copy link
ContributorAuthor

noniagriconomie commentedApr 15, 2019•
edited
Loading

yes i will do it
closed in favor of#11433

@noniagriconomienoniagriconomie deleted the feature-workflow-guard branchApril 15, 2019 13:13
javiereguiluz added a commit that referenced this pull requestApr 16, 2019
This PR was squashed before being merged into the 3.4 branch (closes#11433).Discussion----------[Workflow] Guard documentationHi,Here is a PR for this issue#11214See#11421Commits-------07ada7f [Workflow] Guard documentation
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

+1 more reviewer

@pbowyerpbowyerpbowyer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@noniagriconomie@pbowyer@lyrixx@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp