Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Show how to configure redis provider#11364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Nyholm wants to merge5 commits intosymfony:3.4fromNyholm:issue-10989

Conversation

@Nyholm
Copy link
Member

@NyholmNyholm commentedApr 8, 2019•
edited
Loading

This will properlyfix#10989
Im not 100% confident on the xml configuration.

@nicolas-grekas is this a good description of the Provider?

@NyholmNyholm changed the base branch frommaster to3.4April 8, 2019 16:59
@NyholmNyholm changed the titleShow how to configure redis provider[Cache] Show how to configure redis providerApr 8, 2019
@javiereguiluz
Copy link
Member

@xabbuh could you please double check the XML config? Thanks!

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

XML looks good!

Looking at the XmlFileLoader, I it seems likekey is used instead of name, butkey defaults to name. So I thinkname looks more logical?

@Nyholm
Copy link
MemberAuthor

Nyholm commentedApr 9, 2019•
edited
Loading

I did a quick search. Using "key" is standard on all other places in the docs

@Nyholm
Copy link
MemberAuthor

Thank you for the reviews!

javiereguiluz added a commit that referenced this pull requestApr 9, 2019
This PR was squashed before being merged into the 3.4 branch (closes#11364).Discussion----------[Cache] Show how to configure redis providerThis will properlyfix#10989Im not 100% confident on the xml configuration.@nicolas-grekas is this a good description of the Provider?Commits-------120a87e [Cache] Show how to configure redis provider
@javiereguiluz
Copy link
Member

Thanks Tobias (and reviewers) for another nice Cache contribution.

Nyholm reacted with thumbs up emoji

@NyholmNyholm deleted the issue-10989 branchApril 9, 2019 14:31
@NyholmNyholm mentioned this pull requestApr 9, 2019
wouterj added a commit that referenced this pull requestApr 9, 2019
This PR was merged into the 3.4 branch.Discussion----------[Cache] Syntax fixI made a typo in#11364Commits-------f21b15a [Cache] Syntax fix
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@wouterjwouterjwouterj approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@Nyholm@javiereguiluz@nicolas-grekas@wouterj@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp