Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[serializer] document DEEP_OBJECT_TO_POPULATE#11344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:masterfromdbu:document-serializer-deep-populate
Apr 7, 2019
Merged

[serializer] document DEEP_OBJECT_TO_POPULATE#11344

wouterj merged 1 commit intosymfony:masterfromdbu:document-serializer-deep-populate
Apr 7, 2019

Conversation

@dbu
Copy link
Contributor

@dbudbu commentedApr 7, 2019

Document the new feature added insymfony/symfony#30607

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

with minor comments

@xabbuhxabbuh added this to the4.3 milestoneApr 7, 2019
@OskarStarkOskarStark added the Waiting Code MergeDocs for features pending to be merged labelApr 7, 2019
@wouterjwouterj merged commit7ea06fa intosymfony:masterApr 7, 2019
wouterj added a commit that referenced this pull requestApr 7, 2019
This PR was merged into the master branch.Discussion----------[serializer] document DEEP_OBJECT_TO_POPULATEDocument the new feature added insymfony/symfony#30607Commits-------7ea06fa document DEEP_OBJECT_TO_POPULATE
wouterj added a commit that referenced this pull requestApr 7, 2019
@wouterj
Copy link
Member

Thank you@dbu! I've done a couple changes (mostly moving stuff out of the versionadded) infed4d14 . Let me know if you disagree with anything.

@dbu
Copy link
ContributorAuthor

dbu commentedApr 8, 2019•
edited
Loading

ah, cool! the way you edited it is much better because we can remove the versionadded thing without rewriting any of the rest. i was afraid of people on older versions reading the doc and not noticing that its about a new feature, but if doc is written the way you edited it, its better readable.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Labels

⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-comingSerializerStatus: ReviewedWaiting Code MergeDocs for features pending to be merged

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@dbu@wouterj@xabbuh@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp