Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Add documentation for the Redis transport#11341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
OskarStark left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sometimes Redis and sometimes redis is written, we should only use one consistently
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
…ander-schranz)This PR was merged into the 4.3-dev branch.Discussion----------[Messenger] Add a redis stream transport| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | Yes| Fixed tickets | #28681| License | MIT| Doc PR |symfony/symfony-docs#11341As discussed in #28681 this will refractor@soyuka implementation of redis using the redis stream features so we don't need to handle parking the messages ourself and redis is doing it for us.Some interesting links about streams: -https://redis.io/topics/streams-intro -https://brandur.org/redis-streams```+-----------R| GET | -> XREADGROUP+-----------+ | | handleMessage V+-----------+ No| failed? |---------------------------++-----------+ | | | | Yes | V |+-----------+ No || retry? |---------------------------++-----------+ | | | | Yes | V V+-----------R +-----------R| REJECT | -> XDEL | ACK | -> XACK+-----------+ +-----------+```**GET**: Will use `XREADGROUP` to read the one message from the stream**REJECT**: Reject will just remove the message with `XDEL` from the stream as adding it back to the stream is handled by symfony worker itself**ACK**: Will use the `XACK` Method to ack the message for the specific groupThe sender will still be simple by calling the `XADD` redis function.#EU-FOSSACommits-------ff0b8554ea Refractor redis transport using redis streams7162d2ec1d Implement redis transport
…ander-schranz)This PR was merged into the 4.3-dev branch.Discussion----------[Messenger] Add a redis stream transport| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | Yes| Fixed tickets |#28681| License | MIT| Doc PR |symfony/symfony-docs#11341As discussed in#28681 this will refractor@soyuka implementation of redis using the redis stream features so we don't need to handle parking the messages ourself and redis is doing it for us.Some interesting links about streams: -https://redis.io/topics/streams-intro -https://brandur.org/redis-streams```+-----------R| GET | -> XREADGROUP+-----------+ | | handleMessage V+-----------+ No| failed? |---------------------------++-----------+ | | | | Yes | V |+-----------+ No || retry? |---------------------------++-----------+ | | | | Yes | V V+-----------R +-----------R| REJECT | -> XDEL | ACK | -> XACK+-----------+ +-----------+```**GET**: Will use `XREADGROUP` to read the one message from the stream**REJECT**: Reject will just remove the message with `XDEL` from the stream as adding it back to the stream is handled by symfony worker itself**ACK**: Will use the `XACK` Method to ack the message for the specific groupThe sender will still be simple by calling the `XADD` redis function.#EU-FOSSACommits-------ff0b855 Refractor redis transport using redis streams7162d2e Implement redis transport
dce0577 toc22fadeCompare…chranz)This PR was submitted for the master branch but it was squashed and merged into the 4.3 branch instead (closes#11341).Discussion----------Add documentation for the Redis transportThis will add documentation how to configure and using the redis transport with the messenger component.symfony/symfony#30917#EUFOSSACommits-------c22fade Add documentation for the Redis transport
wouterj commentedMay 11, 2019
Congratz on your code merge and many thanks for providing docs@alexander-schranz! I've added the versionadded directive indaaf7b2, but apart from that this was perfect. |
* 4.3: Fix PHP-CS link Update serializer.rst [#11341] Added versionadded directive Add documentation for the Redis transport Typo Fix usage of StaticJwtProvider added a note about testing newer versions of Symfony fix indention
…ander-schranz)This PR was merged into the 4.3-dev branch.Discussion----------[Messenger] Add a redis stream transport| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | Yes| Fixed tickets | #28681| License | MIT| Doc PR |symfony/symfony-docs#11341As discussed in #28681 this will refractor@soyuka implementation of redis using the redis stream features so we don't need to handle parking the messages ourself and redis is doing it for us.Some interesting links about streams: -https://redis.io/topics/streams-intro -https://brandur.org/redis-streams```+-----------R| GET | -> XREADGROUP+-----------+ | | handleMessage V+-----------+ No| failed? |---------------------------++-----------+ | | | | Yes | V |+-----------+ No || retry? |---------------------------++-----------+ | | | | Yes | V V+-----------R +-----------R| REJECT | -> XDEL | ACK | -> XACK+-----------+ +-----------+```**GET**: Will use `XREADGROUP` to read the one message from the stream**REJECT**: Reject will just remove the message with `XDEL` from the stream as adding it back to the stream is handled by symfony worker itself**ACK**: Will use the `XACK` Method to ack the message for the specific groupThe sender will still be simple by calling the `XADD` redis function.#EU-FOSSACommits-------ff0b8554ea Refractor redis transport using redis streams7162d2ec1d Implement redis transport
Uh oh!
There was an error while loading.Please reload this page.
This will add documentation how to configure and using the redis transport with the messenger component.
symfony/symfony#30917
#EUFOSSA