Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add documentation for the Redis transport#11341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexander-schranz
Copy link
Contributor

@alexander-schranzalexander-schranz commentedApr 7, 2019
edited
Loading

This will add documentation how to configure and using the redis transport with the messenger component.

symfony/symfony#30917

#EUFOSSA

@wouterjwouterj added ⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Waiting Code MergeDocs for features pending to be merged labelsApr 7, 2019
@wouterjwouterj added this to thenext milestoneApr 7, 2019
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sometimes Redis and sometimes redis is written, we should only use one consistently

@alexander-schranzalexander-schranz changed the titleAdd documentation for the redis transportAdd documentation for the Redis transportApr 18, 2019
symfony-splitter pushed a commit to symfony/messenger that referenced this pull requestApr 27, 2019
…ander-schranz)This PR was merged into the 4.3-dev branch.Discussion----------[Messenger] Add a redis stream transport| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | Yes| Fixed tickets | #28681| License       | MIT| Doc PR        |symfony/symfony-docs#11341As discussed in #28681 this will refractor@soyuka implementation of redis using the redis stream features so we don't need to handle parking the messages ourself and redis is doing it for us.Some interesting links about streams: -https://redis.io/topics/streams-intro -https://brandur.org/redis-streams```+-----------R|    GET    | -> XREADGROUP+-----------+      |      | handleMessage      V+-----------+  No|  failed?  |---------------------------++-----------+                           |      |                                 |      | Yes                             |      V                                 |+-----------+  No                       ||   retry?  |---------------------------++-----------+                           |      |                                 |      | Yes                             |      V                                 V+-----------R                     +-----------R|   REJECT  | -> XDEL             |    ACK    | -> XACK+-----------+                     +-----------+```**GET**: Will use `XREADGROUP` to read the one  message from the stream**REJECT**: Reject will just remove the message with `XDEL` from the stream as adding it back to the stream is handled by symfony worker itself**ACK**: Will use the `XACK` Method to ack the message for the specific groupThe sender will still be simple by calling the `XADD` redis function.#EU-FOSSACommits-------ff0b8554ea Refractor redis transport using redis streams7162d2ec1d Implement redis transport
fabpot added a commit to symfony/symfony that referenced this pull requestApr 27, 2019
…ander-schranz)This PR was merged into the 4.3-dev branch.Discussion----------[Messenger] Add a redis stream transport| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | Yes| Fixed tickets |#28681| License       | MIT| Doc PR        |symfony/symfony-docs#11341As discussed in#28681 this will refractor@soyuka implementation of redis using the redis stream features so we don't need to handle parking the messages ourself and redis is doing it for us.Some interesting links about streams: -https://redis.io/topics/streams-intro -https://brandur.org/redis-streams```+-----------R|    GET    | -> XREADGROUP+-----------+      |      | handleMessage      V+-----------+  No|  failed?  |---------------------------++-----------+                           |      |                                 |      | Yes                             |      V                                 |+-----------+  No                       ||   retry?  |---------------------------++-----------+                           |      |                                 |      | Yes                             |      V                                 V+-----------R                     +-----------R|   REJECT  | -> XDEL             |    ACK    | -> XACK+-----------+                     +-----------+```**GET**: Will use `XREADGROUP` to read the one  message from the stream**REJECT**: Reject will just remove the message with `XDEL` from the stream as adding it back to the stream is handled by symfony worker itself**ACK**: Will use the `XACK` Method to ack the message for the specific groupThe sender will still be simple by calling the `XADD` redis function.#EU-FOSSACommits-------ff0b855 Refractor redis transport using redis streams7162d2e Implement redis transport
@weaverryanweaverryan removed the Waiting Code MergeDocs for features pending to be merged labelApr 27, 2019
@wouterjwouterj changed the base branch frommaster to4.3May 11, 2019 19:19
@wouterjwouterjforce-pushed thefeature/redis-messenger branch fromdce0577 toc22fadeCompareMay 11, 2019 19:19
@wouterjwouterj merged commitc22fade intosymfony:4.3May 11, 2019
wouterj added a commit that referenced this pull requestMay 11, 2019
…chranz)This PR was submitted for the master branch but it was squashed and merged into the 4.3 branch instead (closes#11341).Discussion----------Add documentation for the Redis transportThis will add documentation how to configure and using the redis transport with the messenger component.symfony/symfony#30917#EUFOSSACommits-------c22fade Add documentation for the Redis transport
wouterj added a commit that referenced this pull requestMay 11, 2019
@wouterj
Copy link
Member

Congratz on your code merge and many thanks for providing docs@alexander-schranz! I've added the versionadded directive indaaf7b2, but apart from that this was perfect.

OskarStark added a commit that referenced this pull requestMay 13, 2019
* 4.3:  Fix PHP-CS link  Update serializer.rst  [#11341] Added versionadded directive  Add documentation for the Redis transport  Typo  Fix usage of StaticJwtProvider  added a note about testing newer versions of Symfony  fix indention
symfony-splitter pushed a commit to symfony/messenger that referenced this pull requestJan 28, 2020
…ander-schranz)This PR was merged into the 4.3-dev branch.Discussion----------[Messenger] Add a redis stream transport| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | Yes| Fixed tickets | #28681| License       | MIT| Doc PR        |symfony/symfony-docs#11341As discussed in #28681 this will refractor@soyuka implementation of redis using the redis stream features so we don't need to handle parking the messages ourself and redis is doing it for us.Some interesting links about streams: -https://redis.io/topics/streams-intro -https://brandur.org/redis-streams```+-----------R|    GET    | -> XREADGROUP+-----------+      |      | handleMessage      V+-----------+  No|  failed?  |---------------------------++-----------+                           |      |                                 |      | Yes                             |      V                                 |+-----------+  No                       ||   retry?  |---------------------------++-----------+                           |      |                                 |      | Yes                             |      V                                 V+-----------R                     +-----------R|   REJECT  | -> XDEL             |    ACK    | -> XACK+-----------+                     +-----------+```**GET**: Will use `XREADGROUP` to read the one  message from the stream**REJECT**: Reject will just remove the message with `XDEL` from the stream as adding it back to the stream is handled by symfony worker itself**ACK**: Will use the `XACK` Method to ack the message for the specific groupThe sender will still be simple by calling the `XADD` redis function.#EU-FOSSACommits-------ff0b8554ea Refractor redis transport using redis streams7162d2ec1d Implement redis transport
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

+1 more reviewer

@ToflarToflarToflar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-comingMessengerStatus: Reviewed

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

6 participants

@alexander-schranz@wouterj@Toflar@OskarStark@weaverryan@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp