Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Routing] Service route loaders tag#11337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 tasks
Member
wouterj commentedApr 7, 2019
Seems like you changed the single to double colon thing in both of your PRs. Can you remove it from one PR? (and if it's deprecated in 3.4 or 4.2, maybe create a new PR with that change based on the correct branch?) |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
fc952d2 toe51a3f6CompareContributorAuthor
fancyweb commentedApr 7, 2019
@wouterj it has been deprecated since 4.1. I will create another MR for a fix on 4.2. |
wouterj approved these changesApr 10, 2019
e51a3f6 toeb1cd3dCompareContributorAuthor
fancyweb commentedMay 6, 2019
The code has been approved but with a change in the tag name. I just updated the doc accordingly. |
OskarStark approved these changesMay 6, 2019
eb1cd3d to4aee349CompareContributor
OskarStark commentedAug 1, 2019
@fancyweb does it now belong to:symfony/symfony#32582 ? |
ContributorAuthor
fancyweb commentedAug 1, 2019
No it's forsymfony/symfony#32598 |
Contributor
OskarStark commentedAug 1, 2019
Ok, thank you, so the label |
fabpot added a commit to symfony/symfony that referenced this pull requestAug 9, 2019
…rs (fancyweb)This PR was merged into the 4.4 branch.Discussion----------[FrameworkBundle][Routing] Private service route loaders| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#30402| License | MIT| Doc PR |symfony/symfony-docs#11337Continuation of#30926.~Please review only the 2nd commit, I'm building this on top of#32582Commits-------64aa2c8 [FrameworkBundle][Routing] Private service route loaders
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestAug 9, 2019
…rs (fancyweb)This PR was merged into the 4.4 branch.Discussion----------[FrameworkBundle][Routing] Private service route loaders| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |symfony/symfony#30402| License | MIT| Doc PR |symfony/symfony-docs#11337Continuation ofsymfony/symfony#30926.~Please review only the 2nd commit, I'm building this on top ofsymfony/symfony#32582Commits-------64aa2c8529 [FrameworkBundle][Routing] Private service route loaders
4aee349 to8397b67Comparewouterj added a commit that referenced this pull requestAug 12, 2019
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestAug 12, 2019
* upstream/4.4: [symfony#11337] Added a deprecation directive [Routing] Route loader service tag
Member
wouterj commentedAug 12, 2019
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull requestAug 12, 2019
* 4.4: Sort imports alphabetically cleaning up some use statements, etc Update routing.rst [symfony#11337] Added a deprecation directive [Routing] Route loader service tag
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming RoutingStatus: Reviewed
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
#eufossa
doc forsymfony/symfony#32598