Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Routing] Invokable route loader services#11333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 tasks
a3d69dd tod9b4121Comparenicolas-grekas added a commit to symfony/symfony that referenced this pull requestApr 7, 2019
…der services (fancyweb)This PR was merged into the 4.3-dev branch.Discussion----------[Routing][ObjectRouteLoader] Allow invokable route loader services| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR |symfony/symfony-docs#11333#eufossaFall back by default on the `__invoke` method when it is not configured.Using a regex is easier to check that the format is valid, at least for the time we have to supports the single column notation.TODO :- [x] Changelog entry- [x] Doc PRCommits-------5bf7ad4 [Routing][ObjectRouteLoader] Allow invokable route loader services
OskarStark approved these changesApr 7, 2019
Member
wouterj commentedApr 7, 2019
Thanks for updating the docs for your code contributions, Thomas! |
wouterj added a commit that referenced this pull requestApr 7, 2019
This PR was merged into the master branch.Discussion----------[Routing] Invokable route loader services#eufossadoc forsymfony/symfony#30933Also the notation with one column has been deprecated so I updated this part as well.Commits-------d9b4121 [Routing] Invokable route loader services
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming RoutingStatus: Reviewed
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
#eufossa
doc forsymfony/symfony#30933
Also the notation with one column has been deprecated so I updated this part as well.