Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add a documentation about Messenger's transports#11331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@llaakkkk
Copy link

@llaakkkkllaakkkk commentedApr 7, 2019
edited
Loading

Closes#9756

@wouterjwouterj added the ⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming labelApr 7, 2019
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great work so far 👍


class YourTransport implements TransportInterface
{
public function send($message) : void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
public function send($message) : void
public function send($message)

or does it come from the interface?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The method in theSenderInterface looks like this:

publicfunction send(Envelope$envelope):Envelope;

// ...
}

public function stop() : void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
public function stop() : void
public function stop()

or does it come from the interface?

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great PR! Thanks for your work. I've left quite some comments, but I think they should not be hard to fix.

@weaverryan
Copy link
Member

Just took a quick look - thanks for starting this :). There’s one if problem immediately - it looks like this is a few weeks out of date, and s lot has happened in the past few weeks. Check out the master branch of the code - it’s quite different. Sorry about that!

@llaakkkk
Copy link
Author

Thanks all for the review.
I have an error/home/travis/build/symfony/symfony-docs/components/messenger/transports.rst:: WARNING: document isn't included in any toctree
Help please, how to fix it? What does toctree mean?

@llaakkkk
Copy link
Author

Just took a quick look - thanks for starting this :). There’s one if problem immediately - it looks like this is a few weeks out of date, and s lot has happened in the past few weeks. Check out the master branch of the code - it’s quite different. Sorry about that!

Could you please help me with that? which major parts are changed?

@OskarStark
Copy link
Contributor

@weaverryan can you please check if this PR is still relevant, compared against the current state of the messenger docs?

Thank you

@weaverryan
Copy link
Member

I think due to the many changes in this component since this PR was opened (sorry!) and the fact that I think this is a more advanced thing where looking at the core classes themselves is probably the best way to navigate it, I think we should close this. The only missing thing would probably be something in the mainmessenger.rst documentation that mentions how to "wire in" a custom transport (e.g.TransportFactoryInterface autoconfiguration ormessenger.transport_factory tag).

@javiereguiluz
Copy link
Member

We're closing this pull request for the reasons given by Ryan in the previous message.@llaakkkk I'm really sorry about this. I hate it when "external changes" force us to close some pull request because the proposed changes are no longer required or for any other reason. Luckily this doesn't happen often ... but sometimes does happen, like this time 😢 I hope this doesn't discourage you from making future contributions. We'll be happy to merge them! Thanks.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@weaverryanweaverryanweaverryan left review comments

@wouterjwouterjwouterj requested changes

@OskarStarkOskarStarkOskarStark requested changes

@xabbuhxabbuhxabbuh left review comments

+1 more reviewer

@greg0iregreg0iregreg0ire left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-comingMessengerStatus: Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@llaakkkk@weaverryan@OskarStark@javiereguiluz@greg0ire@wouterj@xabbuh@carsonbot@sroze

[8]ページ先頭

©2009-2025 Movatter.jp