Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Link to review comments documentation#11325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
linaori approved these changesApr 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great!
dbrumann approved these changesApr 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks
xabbuh approved these changesApr 6, 2019
The reviews comment documentation can be difficult to find, adding this link will helpmore people read through it.
wouterj added a commit that referenced this pull requestApr 6, 2019
wouterj added a commit that referenced this pull requestApr 6, 2019
* 3.4: [#11325] Use correct line lengths Link to review comments documentation escape backslashes in class role
wouterj added a commit that referenced this pull requestApr 6, 2019
* 4.2: [#11325] Use correct line lengths Link to review comments documentation
wouterj added a commit that referenced this pull requestApr 6, 2019
wouterj added a commit that referenced this pull requestApr 6, 2019
* 4.2: [#11325] Use correct line lengths Link to review comments documentation
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Status: Reviewed
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviews comment documentation can be difficult to find, adding this link will help to get more people read through it. Which will in the end hopefully lead to less misunderstandings :)