Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add documentation for therequire env processor#11313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:masterfrommpdude:docs-for-30897
Apr 7, 2019

Conversation

@mpdude
Copy link
Contributor

Documentation forsymfony/symfony#30897, discussed on the FOSSHackathon.

@wouterjwouterj added the ⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming labelApr 6, 2019
@javiereguiluzjaviereguiluz added the Waiting Code MergeDocs for features pending to be merged labelApr 6, 2019
@wouterjwouterj added this to thenext milestoneApr 6, 2019
Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for creating the documentation directly after submitting the PHP code!!

Once it's merged in the code, we should not forget to add a versionadded directive indicating when this feature was introduced.

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add a versionadded directive like for the url env car processor

@mpdude
Copy link
ContributorAuthor

@OskarStark latest version added a versionadded notice

OskarStark reacted with thumbs up emoji

symfony-splitter pushed a commit to symfony/dependency-injection that referenced this pull requestApr 7, 2019
This PR was merged into the 4.3-dev branch.Discussion----------[DIC] Add a `require` env var processor| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |symfony/symfony-docs#11313This adds a new `require` processor that will `require()` the PHP file given as input value and return the value `return`ed from that file. Leverages opcaching (yay!).#EUFOSSACommits-------03da3a22b1 Add a `require` env var processor
nicolas-grekas added a commit to symfony/symfony that referenced this pull requestApr 7, 2019
This PR was merged into the 4.3-dev branch.Discussion----------[DIC] Add a `require` env var processor| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |symfony/symfony-docs#11313This adds a new `require` processor that will `require()` the PHP file given as input value and return the value `return`ed from that file. Leverages opcaching (yay!).#EUFOSSACommits-------03da3a2 Add a `require` env var processor
@OskarStarkOskarStark removed the Waiting Code MergeDocs for features pending to be merged labelApr 7, 2019
@wouterj
Copy link
Member

Thanks again Matthias!

OskarStark reacted with thumbs up emoji

@wouterjwouterj merged commit1011b42 intosymfony:masterApr 7, 2019
wouterj added a commit that referenced this pull requestApr 7, 2019
…ude)This PR was squashed before being merged into the master branch (closes#11313).Discussion----------Add documentation for the `require` env processorDocumentation forsymfony/symfony#30897, discussed on the FOSSHackathon.Commits-------1011b42 Add documentation for the `require` env processor
@mpdudempdude deleted the docs-for-30897 branchApril 8, 2019 20:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj left review comments

@OskarStarkOskarStarkOskarStark approved these changes

+2 more reviewers

@dbrumanndbrumanndbrumann approved these changes

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-comingStatus: Reviewed

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

7 participants

@mpdude@wouterj@OskarStark@dbrumann@maxhelias@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp