Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Remove GitHub references#11306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Remove GitHub references#11306
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
wouterj approved these changesApr 6, 2019
Contributor
OskarStark commentedApr 6, 2019
Can you please check why Travis is unhappy? 😕 |
ContributorAuthor
dbrumann commentedApr 6, 2019
It looks like I accidentally removed the file for web_link when rebasing the PR on 3.4. |
OskarStark approved these changesApr 6, 2019
Member
wouterj commentedApr 6, 2019
Great, thanks! It's amazing to see we have 53 (documented) components in 3.4! |
wouterj added a commit that referenced this pull requestApr 6, 2019
This PR was squashed before being merged into the 3.4 branch (closes#11306).Discussion---------- Remove GitHub referencesFixes#11295 for #EUFOSSAI will open a second PR for 4.2 as there are some new components that need to be changed as well, namely:* Mercure* Messenger* VarExporter* WebLinkCommits-------5ee0c1b Remove GitHub references
wouterj added a commit that referenced this pull requestApr 6, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Status: Reviewed
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#11295 for #EUFOSSA
I will open a second PR for 4.2 as there are some new components that need to be changed as well, namely: