Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Documented the deprecation of the Templating component#11231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@javiereguiluz
Copy link
Member

Documentssymfony/symfony#21035 but there are some things I'm not sure about. Please, review.

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree with all changes except the form theming, which I commented on. Did you have more things you were unsure about?

@wouterjwouterj removed the On hold labelApr 6, 2019
@javiereguiluzjaviereguiluz changed the title(WIP) Documented the deprecation of the Templating componentDocumented the deprecation of the Templating componentApr 8, 2019
@javiereguiluz
Copy link
MemberAuthor

Now thatsymfony/symfony#30959 has been merged, this is now ready for the final review.

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

+2 more reviewers

@ycerutoycerutoyceruto approved these changes

@SimperfitSimperfitSimperfit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@javiereguiluz@wouterj@OskarStark@yceruto@Simperfit@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp