Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle][Routing] Added doc for new "template", "redirect" shortcuts#11120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

HeahDude
Copy link
Contributor

@HeahDudeHeahDude commentedMar 9, 2019
edited
Loading

@HeahDudeHeahDude added this to the4.3 milestoneMar 9, 2019
@HeahDudeHeahDude self-assigned thisMar 9, 2019
@HeahDudeHeahDudeforce-pushed thefeat-framework-extended-routing branch from442f259 to455bec3CompareMarch 9, 2019 17:35
@HeahDudeHeahDude added the Waiting Code MergeDocs for features pending to be merged labelMar 10, 2019
@HeahDudeHeahDudeforce-pushed thefeat-framework-extended-routing branch from0020a8b to1c4a138CompareMarch 10, 2019 17:18
@xabbuhxabbuh modified the milestones:4.3,nextMay 9, 2019
@HeahDudeHeahDudeforce-pushed thefeat-framework-extended-routing branch from1c4a138 to463f05fCompareFebruary 4, 2020 18:21
nicolas-grekas added a commit to symfony/symfony that referenced this pull requestFeb 9, 2020
…le template and redirect controllers (HeahDude)This PR was merged into the 5.1-dev branch.Discussion----------[FrameworkBundle][Routing] added Configurators to handle template and redirect controllers| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | let's see| Fixed tickets | partially#24640,#25145| License       | MIT| Doc PR        |symfony/symfony-docs#11120While working onsymfony/symfony-docs#11085, I felt bad about the long notations required for simple [redirects](https://symfony.com/doc/current/routing/redirect_in_config.html) and [templates rendering](https://symfony.com/doc/current/templating/render_without_controller.html) template actions, but I love and use those features since always. Then I gave it a try yesterday night and now I realised I missed#24640 and that#25145 has been closed x).So here we go, here's my WIP. WDYT of this implementation? ping@javiereguiluz?I'm going to open the PR in the docs so we can discuss the DX changes there too, and keep focus on the code here.Cheers!EDIT----This PR now only update PHP-DSL configurators.______________TODO:- [x] gather reviews- ~[x] fix xml schema~- [x] add some tests- ~[ ] handle xsd auto discovery~- [x] rebase on top of#30507- [x] ~add shortcuts for#30514~Commits-------de74794 [FrameworkBundle][Routing] added Configurators to handle template and redirect controllers
@HeahDudeHeahDudeforce-pushed thefeat-framework-extended-routing branch 2 times, most recently from054dbd8 tofeaf032CompareFebruary 14, 2020 21:41
@HeahDudeHeahDudeforce-pushed thefeat-framework-extended-routing branch 2 times, most recently from683ec62 to5ce01f4CompareFebruary 15, 2020 08:42
@HeahDudeHeahDude modified the milestones:next,5.1Feb 15, 2020
@HeahDudeHeahDudeforce-pushed thefeat-framework-extended-routing branch from5ce01f4 to5dd105cCompareFebruary 18, 2020 21:20
@OskarStark
Copy link
Contributor

@HeahDude If I am not wrong, the corresponding code is merged, could you please rebase and remove (If I am right) theWaiting Code Merge label? Thanks

@wouterjwouterj removed the Waiting Code MergeDocs for features pending to be merged labelOct 3, 2020
@wouterj
Copy link
Member

As the feature is reverted from 5.1 and the related PRs are closed, let's close this PR as well. The branch of this PR remains on GitHub and can be used when there is a consensus onsymfony/symfony#28806

@wouterjwouterj closed thisOct 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@B-GalatiB-GalatiB-Galati left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@javiereguiluzjaviereguiluzAwaiting requested review from javiereguiluz

Assignees

@HeahDudeHeahDude

Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

7 participants
@HeahDude@OskarStark@wouterj@nicolas-grekas@B-Galati@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp