Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[FrameworkBundle][Routing] Added doc for new "template", "redirect" shortcuts#11120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
442f259
to455bec3
Compare0020a8b
to1c4a138
Compare1c4a138
to463f05f
Compare…le template and redirect controllers (HeahDude)This PR was merged into the 5.1-dev branch.Discussion----------[FrameworkBundle][Routing] added Configurators to handle template and redirect controllers| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | let's see| Fixed tickets | partially#24640,#25145| License | MIT| Doc PR |symfony/symfony-docs#11120While working onsymfony/symfony-docs#11085, I felt bad about the long notations required for simple [redirects](https://symfony.com/doc/current/routing/redirect_in_config.html) and [templates rendering](https://symfony.com/doc/current/templating/render_without_controller.html) template actions, but I love and use those features since always. Then I gave it a try yesterday night and now I realised I missed#24640 and that#25145 has been closed x).So here we go, here's my WIP. WDYT of this implementation? ping@javiereguiluz?I'm going to open the PR in the docs so we can discuss the DX changes there too, and keep focus on the code here.Cheers!EDIT----This PR now only update PHP-DSL configurators.______________TODO:- [x] gather reviews- ~[x] fix xml schema~- [x] add some tests- ~[ ] handle xsd auto discovery~- [x] rebase on top of#30507- [x] ~add shortcuts for#30514~Commits-------de74794 [FrameworkBundle][Routing] added Configurators to handle template and redirect controllers
Uh oh!
There was an error while loading.Please reload this page.
054dbd8
tofeaf032
Compare683ec62
to5ce01f4
Compare5ce01f4
to5dd105c
Compare@HeahDude If I am not wrong, the corresponding code is merged, could you please rebase and remove (If I am right) the |
As the feature is reverted from 5.1 and the related PRs are closed, let's close this PR as well. The branch of this PR remains on GitHub and can be used when there is a consensus onsymfony/symfony#28806 |
Uh oh!
There was an error while loading.Please reload this page.
Added documentation forsymfony/symfony#30501 andsymfony/symfony#35653