Document the use of ignored_attributes context option#11088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

alanpoulain wants to merge1 commit intosymfony:4.2fromalanpoulain:ignored-attributes-context-option

Closed

Document the use of ignored_attributes context option#11088

alanpoulain wants to merge1 commit intosymfony:4.2fromalanpoulain:ignored-attributes-context-option

Conversation

Copy link

Contributor

alanpoulain commentedMar 5, 2019

This documentation was missing since this PR was merged for 4.2:symfony/symfony#28709

Document the use of ignored_attributes context option

c63e048

carsonbot added the Status: Needs Review label

Mar 5, 2019

javiereguiluz added the Serializer label

Mar 5, 2019

Copy link

Member

javiereguiluz commentedMar 5, 2019

@alanpoulain just asking because I don't know this component well: does this pull request fully document the changes made insymfony/symfony#28709? Thanks.

Copy link

ContributorAuthor

alanpoulain commentedMar 5, 2019

I don't know. But at least it documents this missing thing.

dunglas approved these changes

Mar 6, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Mar 6, 2019

Copy link

Member

dunglas commentedMar 6, 2019

@javiereguiluz no, there is the new default context to document, but it's not very useful whilesymfony/symfony#28927 isn't finished/merged.

I'll take care of documenting this feature (and the other one I introduced recently).

Copy link

Member

dunglas commentedMar 6, 2019

Actually, we should merge#11067 instead of this one.

Copy link

Member

javiereguiluz commentedApr 5, 2019

As suggested, we're closing this in favor of#11067, which was just merged.

@alanpoulain I'm sorry this time your contribution wasn't merged ... but we're looking forward to receive more contributions from you in the future. Thanks!