Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Doc for Allow to choose an index for service locators#11042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:4.3fromXuruDragon:di-tagged-locator
Sep 24, 2019

Conversation

@XuruDragon
Copy link

Here is the doc for the new feature implemented in :symfony/symfony#30348 that follow the featuresymfony/symfony#30257

@javiereguiluzjaviereguiluz changed the title[DependencyInjection] Doc for Allow to choose an index for service lo…[DependencyInjection] Doc for Allow to choose an index for service locatorsMar 4, 2019
@javiereguiluzjaviereguiluz added the Waiting Code MergeDocs for features pending to be merged labelMar 4, 2019
@XuruDragon
Copy link
Author

Done, thanks@OskarStark

OskarStark reacted with thumbs up emoji

@XuruDragonXuruDragonforce-pushed thedi-tagged-locator branch 2 times, most recently fromaccec35 to10cfeb0CompareMarch 11, 2019 10:52
@OskarStarkOskarStark removed the Waiting Code MergeDocs for features pending to be merged labelMar 30, 2019
@OskarStark
Copy link
Contributor

The code is merged so I removed the label.

Copy link
Contributor

@OskarStarkOskarStark left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I left a lot of comments which were all fixed.
I think this one is good to merge.

@XuruDragon
Copy link
Author

Thanks@OskarStark

OskarStark reacted with thumbs up emoji

@OskarStark
Copy link
Contributor

I think we are good to go here.

Note for the mergers: this must go in4.3 branch ❗️

@javiereguiluzjaviereguiluz changed the base branch frommaster to4.3September 24, 2019 08:51
javiereguiluz added a commit that referenced this pull requestSep 24, 2019
…or service locators (Anthony MARTIN)This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes#11042).Discussion----------[DependencyInjection] Doc for Allow to choose an index for service locatorsHere is the doc for the new feature implemented in : [symfony/symfony#30348](symfony/symfony#30348) that follow the feature [symfony/symfony#30257](symfony/symfony#30257)Commits-------d63c298 [DependencyInjection] Doc for Allow to choose an index for service locator collection
@javiereguiluzjaviereguiluz merged commitd63c298 intosymfony:4.3Sep 24, 2019
@javiereguiluz
Copy link
Member

It took us some time ... but this is finally merged!@XuruDragon thanks a lot for your contribution.

@XuruDragon
Copy link
Author

It took us some time ... but this is finally merged!@XuruDragon thanks a lot for your contribution.

No problem, thanks to you to finally merge it ;)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@javiereguiluzjaviereguiluzAwaiting requested review from javiereguiluz

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@XuruDragon@OskarStark@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp