Expanding on repositoryMethod#11029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ThomasLandauer wants to merge2 commits intosymfony:3.4fromThomasLandauer:patch-6

Closed

Expanding on repositoryMethod#11029

ThomasLandauer wants to merge2 commits intosymfony:3.4fromThomasLandauer:patch-6

Conversation

Copy link

Contributor

ThomasLandauer commentedFeb 21, 2019

No description provided.

Expanding on repositoryMethod

db7c439

carsonbot added the Status: Needs Review label

Feb 21, 2019

Removing() since the method name is to be given without it

66e797f

javiereguiluz added a commit that referenced this pull request

Feb 22, 2019

minor#11029Expanding on repositoryMethod (ThomasLandauer)

69aba45

This PR was squashed before being merged into the 3.4 branch (closes#11029).Discussion----------Expanding on repositoryMethodCommits-------25d7a4a Expanding on repositoryMethod

Copy link

Member

javiereguiluz commentedFeb 22, 2019

Thanks Thomas!

javiereguiluz closed this

Feb 22, 2019

ThomasLandauer deleted the patch-6 branch

February 22, 2019 09:58

Copy link

ContributorAuthor

ThomasLandauer commentedFeb 22, 2019

@javiereguiluz: Thanks for fixing "a fieldName => value associative array" - just noticed that I had it wrong yesterday ;-)

Copy link

Member

javiereguiluz commentedFeb 22, 2019

No worries! We always tweak a bit some things while merging. We prefer to not report them in the review because it's annoying to contributors and we can easily fix them ourselves. Thanks!