Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection] Doc for #30257 Allow to choose an index for tagged collection#11009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:4.4fromXuruDragon:di-tagged-itterator
Oct 4, 2020

Conversation

@XuruDragon
Copy link

Here is the doc for the new feature implemented in :symfony/symfony#30257

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some more changes please 🙈 🍻

@XuruDragon
Copy link
Author

XuruDragon commentedFeb 19, 2019
edited
Loading

Some more changes please

Done, thanks@OskarStark

OskarStark reacted with thumbs up emoji

@XuruDragon
Copy link
Author

XuruDragon commentedMar 11, 2019
edited
Loading

Could you please update the PR to tell aboutsymfony/symfony#30348 also? That'd be great :)

I've added aSee also at the end, like i've done for the service locator docs here :#11042

@nicolas-grekas
Copy link
Member

Please note that insymfony/symfony#31463 I'm proposing to change the fallback from FQCN to service id. This PR should be updated accordingly when mine is merged.

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedMay 13, 2019
edited
Loading

symfony/symfony#31463 is now merged with another behavior to document:
when a tagged_locator is used, the index-by attribute defaults to the tag name (minus any "dot" prefix):
!tagged_locator app.foo will collect a servicebar with tagapp.foo {foo: baz} as indexbaz (and fallback to the service idbar when thefoo attribute is not defined.

@javiereguiluz
Copy link
Member

Closing as already merged in#11042, which was identical to this one and documented two different Symfony features (symfony/symfony#30348 andsymfony/symfony#30257). Thanks.

@HypeMC
Copy link
Member

HypeMC commentedSep 29, 2019
edited
Loading

@javiereguiluz I don't think#11042 covers this feature.#11042 is aboutservice locators & the!tagged_locator tag, whereas this PR is abouttagged services &!tagged tag.

Even though they are very similar, they are still two different features, each with its own dedicated page. Currently, theindex_by &default_index_method options of the!tagged tag are not documented anywhere apart from the originalblog post.

Perhaps you should consider reopening this PR since it covers these undocumented features?

@javiereguiluz
Copy link
Member

Let's open then. Thanks.

@HeahDudeHeahDude added this to the4.4 milestoneFeb 7, 2020
..tip::

You can omit the ``index_attribute_name`` attribute, by implementing a static
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree with Javier, the sentence should beYou can omit the ``key`` attribute..., then directly show the usage of

arguments:[!tagged { tag: 'app.handler', index_by: 'key', default_index_method: 'someFunctionName' }]

within the tip, and discard the following.

@wouterjwouterj changed the base branch frommaster to4.4October 4, 2020 11:23
wouterj added a commit that referenced this pull requestOct 4, 2020
@wouterjwouterj merged commit56dd405 intosymfony:4.4Oct 4, 2020
@wouterj
Copy link
Member

Thanks@XuruDragon for creating this PR! This is now merged and I've shortened the changes a bit without loosing any information afterwards in 4ffbc62 .

XuruDragon reacted with thumbs up emoji

wouterj added a commit that referenced this pull requestOct 4, 2020
* 4.4:  [#11009] Some tweaks  [DependencyInjection] Doc for #30257 Allow to choose an index for tagged collection  [#12523] Reworded caution  Add a documentation page for lock in FW  [Configuration] Add documentation about `ignore_errors: not_found` option.
wouterj added a commit that referenced this pull requestOct 4, 2020
* 5.1:  [#11009] Some tweaks  [DependencyInjection] Doc for #30257 Allow to choose an index for tagged collection  [#12523] Reworded caution  Add a documentation page for lock in FW  [Configuration] Add documentation about `ignore_errors: not_found` option.
wouterj added a commit that referenced this pull requestOct 4, 2020
This PR was merged into the 4.4 branch.Discussion----------[DI] replace tagged by tagged_iteratorintroduce with#11009cc@wouterjCommits-------0d75a98 [DI] replace tagged by tagged_iterator
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz left review comments

@weaverryanweaverryanweaverryan left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@OskarStarkOskarStarkOskarStark requested changes

+2 more reviewers

@HeahDudeHeahDudeHeahDude requested changes

@deguifdeguifdeguif approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

10 participants

@XuruDragon@nicolas-grekas@javiereguiluz@HypeMC@wouterj@weaverryan@deguif@OskarStark@HeahDude@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp