Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[DependencyInjection] Doc for #30257 Allow to choose an index for tagged collection#11009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
6c8e145 toc995578CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
c995578 to08ea69eCompareUh oh!
There was an error while loading.Please reload this page.
08ea69e to6ba1286CompareUh oh!
There was an error while loading.Please reload this page.
6ba1286 to4ee4e8fCompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
30626a7 to126d0f2CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
126d0f2 to2b8df41Compare
OskarStark left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some more changes please 🙈 🍻
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
adc95be tob504690CompareXuruDragon commentedFeb 19, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Done, thanks@OskarStark |
XuruDragon commentedMar 11, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I've added a |
6db79cd to5cceab5Comparedcd44ba to338058fComparenicolas-grekas commentedMay 10, 2019
Please note that insymfony/symfony#31463 I'm proposing to change the fallback from FQCN to service id. This PR should be updated accordingly when mine is merged. |
nicolas-grekas commentedMay 13, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
symfony/symfony#31463 is now merged with another behavior to document: |
javiereguiluz commentedSep 27, 2019
Closing as already merged in#11042, which was identical to this one and documented two different Symfony features (symfony/symfony#30348 andsymfony/symfony#30257). Thanks. |
HypeMC commentedSep 29, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@javiereguiluz I don't think#11042 covers this feature.#11042 is aboutservice locators & the Even though they are very similar, they are still two different features, each with its own dedicated page. Currently, the Perhaps you should consider reopening this PR since it covers these undocumented features? |
javiereguiluz commentedSep 30, 2019
Let's open then. Thanks. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| ..tip:: | ||
| You can omit the ``index_attribute_name`` attribute, by implementing a static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree with Javier, the sentence should beYou can omit the ``key`` attribute..., then directly show the usage of
arguments:[!tagged { tag: 'app.handler', index_by: 'key', default_index_method: 'someFunctionName' }]
within the tip, and discard the following.
wouterj commentedOct 4, 2020
Thanks@XuruDragon for creating this PR! This is now merged and I've shortened the changes a bit without loosing any information afterwards in 4ffbc62 . |
Here is the doc for the new feature implemented in :symfony/symfony#30257