Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix encore advanced config watchOptions example#10923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 1 commit intosymfony:3.4fromeXtreme:patch-1
Jan 25, 2019

Conversation

@eXtreme
Copy link
Contributor

I've been struggling with this for some time and couldn't getwatchOptions to work. After a long investigation I addeddevServer to the config and it started working.

So I guess this is the correct example of adding watchOptions to the config.

@javiereguiluz
Copy link
Member

@eXtreme thanks for contributing this. Sadly, I can't reproduce this error. If I add thewatchOptions config as shown in the docs today, it worked for me. I didn't have to add thedevServer option.

This is what I did: I addedaggregateTimeout: 10000 toconfig.watchOptions because it's easy to know if the option is working or not (it will wait 10 seconds before recompiling assets). I quityarn encore dev --watch, started again, and I saw the 10 second delay. (note: at first I did the mistake of not restartingencore after changingwebpack.config.js config and that's why the options didn't work for me).

So, can you please double check if this works for you too? Thanks!

@eXtreme
Copy link
ContributorAuthor

@javiereguiluz when I just dump the config in thewebpack.config.js to console (before addingwatchOptions)

varconfig=Encore.getWebpackConfig();console.log(config);

the output is:

nodejs_1  | { context: '/var/www/symfony',nodejs_1  |   entry: { app: './assets/js/index.js' },nodejs_1  |   mode: 'development',nodejs_1  |   output:nodejs_1  |    { path: '/var/www/symfony/public/build',nodejs_1  |      filename: '[name].js',nodejs_1  |      publicPath: 'http://localhost:8080/',nodejs_1  |      pathinfo: true },nodejs_1  |   module: { rules: [ [Object], [Object], [Object], [Object] ] },nodejs_1  |   plugins:nodejs_1  |    [ MiniCssExtractPlugin { options: [Object] },nodejs_1  |      DeleteUnusedEntriesJSPlugin { entriesToDelete: [] },nodejs_1  |      ManifestPlugin { opts: [Object] },nodejs_1  |      LoaderOptionsPlugin { options: [Object] },nodejs_1  |      CleanWebpackPlugin { paths: [Array], options: [Object] },nodejs_1  |      DefinePlugin { definitions: [Object] },nodejs_1  |      { options: [Object],nodejs_1  |        lastBuildSucceeded: false,nodejs_1  |        isFirstBuild: true },nodejs_1  |      FriendlyErrorsWebpackPlugin {nodejs_1  |        compilationSuccessInfo: [Object],nodejs_1  |        onErrors: undefined,nodejs_1  |        shouldClearConsole: false,nodejs_1  |        formatters: [Array],nodejs_1  |        transformers: [Array] },nodejs_1  |      AssetsWebpackPlugin { options: [Object], writer: [Function: queuedWriter] } ],nodejs_1  |   optimization:nodejs_1  |    { namedModules: true,nodejs_1  |      chunkIds: 'named',nodejs_1  |      runtimeChunk: 'single',nodejs_1  |      splitChunks: { chunks: 'async' } },nodejs_1  |   devtool: 'inline-source-map',nodejs_1  |   devServer:nodejs_1  |    { contentBase: '/var/www/symfony/public',nodejs_1  |      publicPath: 'http://localhost:8080/',nodejs_1  |      headers: { 'Access-Control-Allow-Origin': '*' },nodejs_1  |      hot: true,nodejs_1  |      quiet: true,nodejs_1  |      compress: true,nodejs_1  |      historyApiFallback: true,nodejs_1  |      watchOptions: { ignored: /node_modules/ },nodejs_1  |      https: undefined },nodejs_1  |   performance: { hints: false },nodejs_1  |   stats:nodejs_1  |    { hash: false,nodejs_1  |      version: false,nodejs_1  |      timings: false,nodejs_1  |      assets: false,nodejs_1  |      chunks: false,nodejs_1  |      maxModules: 0,nodejs_1  |      modules: false,nodejs_1  |      reasons: false,nodejs_1  |      children: false,nodejs_1  |      source: false,nodejs_1  |      errors: false,nodejs_1  |      errorDetails: false,nodejs_1  |      warnings: false,nodejs_1  |      publicPath: false,nodejs_1  |      builtAt: false },nodejs_1  |   resolve:nodejs_1  |    { extensions:nodejs_1  |       [ '.wasm', '.mjs', '.js', '.json', '.jsx', '.vue', '.ts', '.tsx' ],nodejs_1  |      alias: {} },nodejs_1  |   externals: {} }

andwatchOptions are underdevServer.

Isn't this because I use the dev server?https://symfony.com/doc/current/frontend/encore/dev-server.html

If so, maybe we should change the docs and add two versions of this snippet, one for "using webpack-dev-server" and one for not using it.

@Lyrkan
Copy link
Contributor

Hi there,

@eXtreme Indeed, if you use the dev server (--dev-server) thewatchOptions have to be filled under thedevServer key. If you don't (yarn encore dev --watch) then you have to put them directly at the root.

That being said there is a pending PR on Encore that should help setting those parameters correctly by introducing anEncore.configureWatchOptions(...) method:symfony/webpack-encore#486

@eXtreme
Copy link
ContributorAuthor

Hi@Lyrkan that indeed looks like a better approach.

@javiereguiluzjaviereguiluz added this to the3.4 milestoneJan 25, 2019
@javiereguiluzjaviereguiluz merged commit06f5c23 intosymfony:3.4Jan 25, 2019
javiereguiluz added a commit that referenced this pull requestJan 25, 2019
This PR was merged into the 3.4 branch.Discussion----------Fix encore advanced config watchOptions exampleI've been struggling with this for some time and couldn't get `watchOptions` to work. After a long investigation I added `devServer` to the config and it started working.So I guess this is the correct example of adding watchOptions to the config.Commits-------06f5c23 Fix encore advanced config watchOptions example
@javiereguiluz
Copy link
Member

@eXtreme thanks! We've merged this, but showing both methods in6f04086. Thanks@Lyrkan for the notice aboutconfigureWatchOptions(). We've added a comment about it to not forget it.

@eXtreme
Copy link
ContributorAuthor

@javiereguiluz that sounds reasonable at this moment, thanks!

@Kocal
Copy link
Member

Kocal commentedMar 1, 2019•
edited
Loading

Hi@javiereguiluz, I've just seen your comment about updating some code whensymfony/webpack-encore#486 will be merged andconfigureWatchOptions() introduced.

Since we don't need to useEncore.getWebpackConfig() for configure watching options, should I replace the following lines with other examples?

// if you run 'encore dev --watch'config.watchOptions={poll:true,ignored:/node_modules/};// if you run 'encore dev-server'config.devServer.watchOptions={poll:true,ignored:/node_modules/};

And of course documentconfigureWatchOptions() method in a new page/section?

Thanks

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@eXtreme@javiereguiluz@Lyrkan@Kocal@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp