Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Validator] Fix@Valid regarding propertytraverse#10868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@corphi
Copy link
Contributor

While researching forsymfony/symfony#27090, the constraint reference turned out to be incorrect.

@corphicorphiforce-pushed theconstraint-valid-traverse branch 2 times, most recently fromfa004a4 to49354b4CompareJanuary 26, 2019 15:15
@corphicorphiforce-pushed theconstraint-valid-traverse branch from49354b4 to8ed269fCompareFebruary 3, 2019 21:01
@javiereguiluzjaviereguiluz added this to the3.4 milestoneFeb 7, 2019
@corphicorphiforce-pushed theconstraint-valid-traverse branch from8ed269f to0836a48CompareFebruary 11, 2019 20:52
set to ``true``.
If this constraint is applied to a``Traversable``, then all containing values
will be validated if this option is set to ``true``. Thisoption is ignored on
arrays: Arrays are traversed in either case. Keys are not validated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should need a correction ifsymfony/symfony#29800 is merged, right?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No,@Valid is working correctly. The docs could just use this clarification. The mentioned pull request is only concerned with other constraints not working correctly.

@corphicorphiforce-pushed theconstraint-valid-traverse branch from0836a48 to6343b24CompareFebruary 19, 2019 22:14
Copy link
Contributor

@HeahDudeHeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@javiereguiluz
Copy link
Member

Thank you@corphi.

@javiereguiluzjaviereguiluz merged commit6343b24 intosymfony:3.4Mar 7, 2019
javiereguiluz added a commit that referenced this pull requestMar 7, 2019
…corphi)This PR was merged into the 3.4 branch.Discussion----------[Validator] Fix `@Valid` regarding property `traverse`While researching forsymfony/symfony#27090, the constraint reference turned out to be incorrect.Commits-------6343b24 Describe actual traversal behaviour
@corphicorphi deleted the constraint-valid-traverse branchMarch 8, 2019 17:57
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@HeahDudeHeahDudeHeahDude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@corphi@javiereguiluz@HeahDude@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp