Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Add Doctrine ORM installation instructions.#10798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This best practices page assumes Doctrine is available and, since it is not, the reader is given a little extra information and a link to know how to make it available and be able to continue through the rest of the examples. This makes it consistent with the Data Fixtures description later on the page.
| ..code-block::terminal | ||
| $ composer require "symfony/orm-pack" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| $ composer require"symfony/orm-pack" | |
| $ composer require symfony/orm-pack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The quotes on the composer line was to keep it consistent with the Data Fixtures section later on the page. In my opinion neither should have quotes but both having quotes is better than one with quotes and one without.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah yes, I see. You could add a commit to remove the quotes over there too to make it consistent across the whole docs in my opinion.
| `Doctrine project`_ to define their model using entities and repositories. | ||
| Doctrine support is not enabled by default in Symfony. So to use Doctrine | ||
| as shown in the examples below you will need to install `Doctrine ORM support`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We can use thedoc role here instead:
:doc:`Doctrine ORM support</doctrine>`
Toflar commentedApr 7, 2019
Thank you very much for your pull request! As part of the Symfony EU funded hackathon (https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming), we were able to assemble most of the core team and big contributors in one place. Our goal is to finish as many open issues and PRs as possible. Your commits will not be lost and you will therefore get credit for your work. All that will happen is that your commits will be moved to a new PR where all remaining concerns will be addressed. Without your work this would not have been possible. So thank you once again! |
xabbuh commentedApr 7, 2019
see#11332 |
…Toflar)This PR was merged into the 3.4 branch.Discussion----------Add doctrine orm installation instructionsFollow up branch of#10798 including the requested changes. Also changed the base branch to 3.4 because it applies there too :)Commits-------6d164c3 Addressed issues raised in (#10798)d579eea Add Doctrine ORM installation instructions.
This best practices page assumes Doctrine is available and, since it is not, the reader is given a little extra information and a link to know how to make it available and be able to continue through the rest of the examples. This makes it consistent with the Data Fixtures description later on the page.