Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Documentation workflow context apply#10751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@noniagriconomie
Copy link
Contributor

@noniagriconomienoniagriconomie commentedDec 8, 2018•
edited
Loading

Hi,

While attending to the #SymfonyConHackday2018

I wanted to test@lyrixx implementation (symfony/symfony#29146) of a request of mine (symfony/symfony#27925) on one of my projects.

I also wanted to add/improve the documentation in the same time.

This PR is WIP as the feature is not merged yet (on its way)

thank you

Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot for working on this feature 👍

@noniagriconomie
Copy link
ContributorAuthor

@lyrixx review addressed

Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@noniagriconomienoniagriconomie changed the title[WIP] Documentation workflow contextDocumentation workflow contextJan 14, 2019
@noniagriconomienoniagriconomie changed the titleDocumentation workflow contextDocumentation workflow context applyJan 14, 2019
@noniagriconomie
Copy link
ContributorAuthor

hi@lyrixx

I do not know if the comment like that is ok (it is a bit weird), wdyt?

Also, do you have a date for the merge of the related feature ? :)

Thank you!

@javiereguiluz
Copy link
Member

@noniagriconomie I'd like to merge your pull request, but I'm seeing lots of conflicts when doing that. Could you please rebase this to the latest changes of the master branch? Thanks!

@noniagriconomie
Copy link
ContributorAuthor

@javiereguiluz of course i will do this asap

javiereguiluz reacted with thumbs up emoji

@noniagriconomie
Copy link
ContributorAuthor

@javiereguiluz Done

Just i am not sure about the "versionadded:: 4.1" part when i rebased

thank you

Copy link
Contributor

@HeahDudeHeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I left some minor comments!

Great contribution so far 💪 thank you!

@noniagriconomie
Copy link
ContributorAuthor

@OskarStark (@HeahDude) reviews addressed, thank you!

OskarStark reacted with thumbs up emoji

Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 Very cool. Thanks for your work.

@Simperfit
Copy link
Contributor

@xabbuh can we merge this one ?

lyrixx and pbowyer reacted with thumbs up emoji

@xabbuhxabbuh added the ⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming labelApr 7, 2019
@xabbuhxabbuhforce-pushed theworkflow-documentation branch from8a7f7c5 toaf0da29CompareApril 7, 2019 11:26
xabbuh added a commit that referenced this pull requestApr 7, 2019
@xabbuh
Copy link
Member

Thank you@noniagriconomie and congratulations on your first contribution to the Symfony documentation. I have merged your PR (I have squased the commits while merging that's why the PR is shown as closed instead of merged) and made some small tweaks ine1e4efc.

noniagriconomie reacted with thumbs up emojiToflar reacted with hooray emojiOskarStark and wouterj reacted with rocket emoji

@xabbuhxabbuh closed thisApr 7, 2019
// ...
}

Symfony also creates automatically for you a service for each workflow (:class:`Symfony\\Component\\Workflow\\Workflow`) or state machine (:class:`Symfony\\Component\\Workflow\\StateMachine`) you have defined in your configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would reword it:

Symfony creates a service for you automatically....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

seee1e4efc :)

OskarStark reacted with laugh emoji
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks


..versionadded::4.1

The:class:`Symfony\\Component\\Workflow\\Exception\\TransitionException`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we Need this versionadded ?

@symfony/team-symfony-docs


..versionadded::4.1

The:method:`Symfony\\Component\\Workflow\\Registry::all` method was
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we Need this versionadded ?

@symfony/team-symfony-docs

@noniagriconomienoniagriconomie deleted the workflow-documentation branchMay 18, 2019 20:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@xabbuhxabbuhxabbuh left review comments

+2 more reviewers

@lyrixxlyrixxlyrixx approved these changes

@HeahDudeHeahDudeHeahDude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

⭐️ EU-FOSSA Hackathonhttps://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-comingStatus: ReviewedWorkflow

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

8 participants

@noniagriconomie@javiereguiluz@Simperfit@xabbuh@lyrixx@OskarStark@HeahDude@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp