Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Document changes in the deprecation error handler#10701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@greg0ire
Copy link
Contributor

Copy link
Member

@TimoBakxTimoBakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very clear documentation.

@llaakkkk
Copy link

Thank you very much for your pull request!

As part of the Symfony EU funded hackathon (https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming), we were able to assemble most of the core team and big contributors in one place. Our goal is to finish as many open issues and PRs as possible.

Your commits will not be lost and you will therefore get credit for your work. All that will happen is that your commits will be moved to a new PR where all remaining concerns will be addressed.

Without your work this would not have been possible. So thank you once again!

fabpot added a commit to symfony/symfony that referenced this pull requestApr 12, 2019
… (greg0ire)This PR was merged into the 4.3-dev branch.Discussion----------[PhpUnitBridge] Url encoded deprecations helper config| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |#28048| License       | MIT| Doc PR        |symfony/symfony-docs#10701First stab at implementing a new way of configuring the deprecation error handler. Includes a refactoring to keep things manageable.Rework of#24867, blocked by#29718TODO:- [x] make the code 5.5 compatible 😢- [x] add more tests- [x] deprecate modes (using echo :P)- [x] test this on real life projects and add some screenshots- [x] docs PR- [x] handle `strict`- [x] adapt existing CI config# Quiet configuration![quiet](https://user-images.githubusercontent.com/657779/49341318-fa78c900-f64b-11e8-9504-a8a9eac4baf8.png)# Default configuration![verbose](https://user-images.githubusercontent.com/657779/49341322-10868980-f64c-11e8-9d90-dc3f6a18c335.png)Commits-------1c73f9c [PhpUnitBridge] Url encoded deprecations helper config
@javiereguiluzjaviereguiluz removed the Waiting Code MergeDocs for features pending to be merged labelApr 26, 2019
@OskarStark
Copy link
Contributor

This one looks finished and the code is merged

@greg0ire
Copy link
ContributorAuthor

greg0ire commentedApr 28, 2019
edited
Loading

@llaakkkk made a PR that supersedes this one, don't merge!

@OskarStark
Copy link
Contributor

Ok so this one can be closed?

@greg0ire
Copy link
ContributorAuthor

It will be autoclosed when the other one is merged

OskarStark and llaakkkk reacted with thumbs up emoji

@greg0iregreg0ire deleted the url_encoded_config branchMay 31, 2019 09:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@TimoBakxTimoBakxTimoBakx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@greg0ire@llaakkkk@OskarStark@TimoBakx@javiereguiluz@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp