Nov 22, 2018 · Nov 23, 2018 · Nov 23, 2018 · Nov 23, 2018 · Nov 23, 2018 · Nov 24, 2018
diff --git a/best_practices/business-logic.rst b/best_practices/business-logic.rst

        /**
         * @ORM\OneToMany(
         *      targetEntity="Comment",
         *      targetEntity="App\Entity\Comment",
         *      mappedBy="post",
         *      orphanRemoval=true
         * )
diff --git a/form/form_collections.rst b/form/form_collections.rst
            // ...

            /**
             * @ORM\ManyToMany(targetEntity="Tag", cascade={"persist"})
             * @ORM\ManyToMany(targetEntity="App\Entity\Tag", cascade={"persist"})
             */
            protected $tags;

                # ...
                oneToMany:
                    tags:
                        targetEntity: Tag
                        targetEntity:App\Entity\Tag
                        cascade:      [persist]

        .. code-block:: xml
diff --git a/reference/constraints/UniqueEntity.rst b/reference/constraints/UniqueEntity.rst
        class Service
        {
            /**
             * @ORM\ManyToOne(targetEntity="Host")
             * @ORM\ManyToOne(targetEntity="App\Entity\Host")
             */
            public $host;
Original file line number	Diff line number	Diff line change
Expand Up		@@ -198,7 +198,7 @@ looking for mapping information::

		/**
		* @ORM\OneToMany(
		* targetEntity="Comment",
		* targetEntity="App\Entity\Comment",
Copy link Contributor kunicmarko20Nov 23, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I think it is better to suggest`Comment::class` because if you refactor namespace it will be picked up and you don't have to edit a bunch of strings Copy link ContributorAuthor osavchenkoNov 23, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. The similar approach was applied before, so I decide to follow it. Do you want to suggest rework everywhere to`ClassNmae::class`? Copy link Contributor kunicmarko20Nov 23, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Ah, then leave it like this in PR. I think reworking it everywhere would be a nice addition. Not sure what docs team thinks about it Copy link ContributorAuthor osavchenkoNov 23, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. If team decide to rework everything, so, I'm in ;) Copy link Member xabbuhNov 24, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Using the class constant doesn't work in annotations if I am not completely mistaken. Copy link Contributor kunicmarko20Nov 24, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. It works, I used it like: `* @ORM\ManyToOne(targetEntity=Comment::class) * @ORM\JoinColumn(name="id", referencedColumnName="id")` When you refactor and maybe change the namespace, it changes the use statements (not sure about strings but it didn't work for me most of the times) so that is an advantage on using`Comment::class` instead of`"App\Entity\Comment"`. Copy link Contributor kunicmarko20Nov 25, 2018• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. After discussing this with@ostrolucky on slack, it seems that: clicking on`mappedBy="foo"`/`inversedBy="foo"` dosen't work with`Comment::class` also if you rename the class it still stays`Comment::class` so I guess FQCN is still better Copy link ContributorAuthor osavchenkoNov 25, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. You mean "clicking on" IDE? Copy link Contributor kunicmarko20Nov 25, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. ye, clicking on the name of the var in your IDE (phpstorm in my case).
		* mappedBy="post",
		* orphanRemoval=true
		* )
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -468,7 +468,7 @@ you will learn about next!).
		// ...

		/**
		* @ORM\ManyToMany(targetEntity="Tag", cascade={"persist"})
		* @ORM\ManyToMany(targetEntity="App\Entity\Tag", cascade={"persist"})
		*/
		protected $tags;

Expand All		@@ -480,7 +480,7 @@ you will learn about next!).
		# ...
		oneToMany:
		tags:
		targetEntity: Tag
		targetEntity:App\Entity\Tag
		cascade: [persist]

		.. code-block:: xml
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -218,7 +218,7 @@ Consider this example:
		class Service
		{
		/**
		* @ORM\ManyToOne(targetEntity="Host")
		* @ORM\ManyToOne(targetEntity="App\Entity\Host")
		*/
		public $host;

Expand Down