delete var_dump() functions in examples#10673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

JakubSzczesniak wants to merge1 commit intosymfony:4.1fromJakubSzczesniak:patch-1

Closed

delete var_dump() functions in examples#10673

JakubSzczesniak wants to merge1 commit intosymfony:4.1fromJakubSzczesniak:patch-1

Conversation

Copy link

Contributor

JakubSzczesniak commentedNov 14, 2018

No description provided.

delete var_dump() functions in examples

a09d197

carsonbot added the Status: Needs Review label

Nov 14, 2018

kunicmarko20 approved these changes

Nov 14, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Nov 14, 2018

javiereguiluz added the EventDispatcher label

Nov 15, 2018

javiereguiluz added this to the2.8 milestone

Nov 15, 2018

Copy link

Member

javiereguiluz commentedNov 15, 2018

Jakub, thanks for removing these strange var_dump() calls. We merged it in 2.8 (the oldest maintained branch that contains the bug ... and we'll merge it in the other branches later automatically). Congrats on your first Symfony Docs contribution!

javiereguiluz added a commit that referenced this pull request

Nov 15, 2018

minor#10673delete var_dump() functions in examples (JakubSzczesniak)

0d05c85

This PR was submitted for the 4.1 branch but it was merged into the 2.8 branch instead (closes#10673).Discussion----------delete var_dump() functions in examplesCommits-------04501ea delete var_dump() functions in examples

javiereguiluz closed this

Nov 15, 2018