Http kernel controller arguments#10640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ottaviano wants to merge2 commits intosymfony:masterfromottaviano:http-kernel-controller-arguments

Closed

Http kernel controller arguments#10640

ottaviano wants to merge2 commits intosymfony:masterfromottaviano:http-kernel-controller-arguments

Conversation

Copy link

Contributor

ottaviano commentedNov 6, 2018

Hi,
I saw the issue#6854, and I can not write full & clear doc to describe thekernel.controller_arguments event.
But I think that it will be nice to have this event in the list of all Kernel events.

I fix thekernel.finish_request event description. This event is triggered afterkernel.response event (not only for a sub-request).

carsonbot added the Status: Needs Review label

Nov 6, 2018

ottaviano added2 commits

November 9, 2018 10:16

[HttpKernel] Add kernel.controller_arguments to the list of Events

f75f438

[HttpKernel] Fix kernel.finish_request doc

36d3677

ottaviano force-pushed thehttp-kernel-controller-arguments branch fromeb43c48 to36d3677Compare

November 9, 2018 09:17

Copy link

Member

nicolas-grekas commentedNov 10, 2018

Thekernel.controller_arguments event is triggered just before a controller is called, and is a hook that allows configuring the arguments that are going to be passed to the controller. Typically, this is used to map URL routing parameters to their corresponding named arguments; or pass the current request when theRequest type hint is found.

Copy link

ContributorAuthor

ottaviano commentedNov 10, 2018

@nicolas-grekas, it seems that it was not enough as an explication2 years ago

javiereguiluz added Status: Reviewed HttpKernel and removed Status: Needs Review labels

Apr 5, 2019

javiereguiluz added this to the3.4 milestone

Apr 5, 2019

javiereguiluz added a commit that referenced this pull request

Apr 5, 2019

minor#10640Http kernel controller arguments (ottaviano)

0a21fa5

This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes#10640).Discussion----------Http kernel controller argumentsHi,I saw the issue#6854, and I can not write full & clear doc to describe the `kernel.controller_arguments` event.But I think that it will be nice to have this event in the list of all Kernel events.I fix the `kernel.finish_request` event description. This event is triggered after `kernel.response` event (not only for a sub-request).Commits-------cd5fe5a Http kernel controller arguments