Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Fixes security authentication provider cookbook article#1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fixes security authentication provider cookbook article#1050
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…icle in favor of adding the extension in the Bundle.
Hi Brent old friend! So really nice job identifying the 2.1 changes, here's how this needs to work:
The easiest way to do this might be to make (1) first, let me merge it in, let me merge 2.0 to master, and then do the second one based off of the new master. If you can strip off the 2.1 commit from this PR, then I can get that rolling. Thanks! |
I created this PR for 1, and will commit 2 as soon as that is merged into the master branch Next time I'm submitting a PR to Leanna. I bet she would be nicer :) |
Addresses this issue:
#1033
This fixes the listener to always return a 403 when the request is not WSSE. This was previously cause for much confusion.
Also, it seems the
security_factoriesconfiguration key is no longer valid, so we are now initializing the security factory as part of theAcmeDemoBundle. This is how it's done in core, but if there's a better way I will change it.The diffs are confusing as hell for some reason. The listener is changed now so the logic is wrapped in a conditional, and the security_factories portion is replaced by a code sample from AcmeDemoBundle.
Let me know if you have any questions!