Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Replace extra ...#10475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Replace extra ...#10475
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I suppose this `...` should be replaced with simple comma. Also should be fixed in 3.3 documentation, but this branch is not allowed to be edited.
| Imagine you're building an API to publish statuses on a Twitter feed, obfuscated | ||
| with `ROT13`_... a fun encoder that shifts all characters 13 letters forward in | ||
| with `ROT13`_, a fun encoder that shifts all characters 13 letters forward in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not sure if we need thefun in the sentence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's not strictly needed ... but let's keep it :)
javiereguiluz commentedOct 12, 2018
Thanks@u-mulder. |
This PR was merged into the 3.4 branch.Discussion----------Replace extra ...I suppose this `...` should be replaced with simple comma. Also should be fixed in 3.3 documentation, but this branch is not allowed to be edited.<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/roadmap for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `master` for features of unreleased versions).-->Commits-------1d1f8ec Replace extra ...
I suppose this
...should be replaced with simple comma. Also should be fixed in 3.3 documentation, but this branch is not allowed to be edited.