Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Mentioned how to redirect and maintain the query string#10373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| return $this->redirectToRoute('blog_show', array('slug' => 'my-page')); | ||
| // redirects to a route and mantains the original query string parameters | ||
| return $this->redirectToRoute('blog_show', $request->query->all()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This change looks good! I'm just thinking, would it be worth it having the base controller support the following syntax?
return$this->redirectToRoute('blog_show',$request->query);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In my opinion it's better to not add a new way to get the query string params. Let's keep things simple and minimize the number of methods/features to learn. Thanks!
…(javiereguiluz)This PR was merged into the 2.8 branch.Discussion----------Mentioned how to redirect and maintain the query stringThisfixessymfony/symfony#27482.Commits-------71d6ab1 Mentioned how to redirect and maintain the query string
Thisfixessymfony/symfony#27482.