Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WCM] Encore updates for Webpack 4#10322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 7 commits intosymfony:3.4fromweaverryan:encore-webpack4
Nov 5, 2018

Conversation

@weaverryan
Copy link
Member

@weaverryanweaverryan commentedSep 11, 2018
edited
Loading

Phew! The next (unreleased) version of Webpack Encore (will be 0.21.0) that supports Webpack 4 will contain a few minor changes, that have major implications on the documentation. Ultimately, I think the experience will be easier for users :). The 3 big changes are:

  1. In all cases, people should use the new WebpackEncoreBundle and its 2 new Twig functions -encore_entry_script_tags() andencore_entry_link_tags() to render theirscript andlink tags.

  2. In earlier versions, an extramanifest.js file was output when usingcreatedSharedEntry(). But now, a newruntime.js file isalways output. But, because of theencore_entry_script_tags() shortcut... that's just rendered for you automatically.

  3. createSharedEntry() is no longer hipster ;). This is from changes in Webpack. A newer, and better "split chunks" feature replaces it... which (other than changing how existing users think), is much simpler. Basically, the user does nothing... except callencore_entry_script_tags(). But, when this feature is enabled, the final.js and.css files may be split into multiple files. And so, theencore_entry_script_tags() (and also the link version) may rendermultiple script tags. This all happens automatically.

TODO: Wait for the bundle to be tagged, then test the new recipe (symfony/recipes#458) and code through some of the docs to catch any mistakes (due to so many changes).

Merging into 4.1 TODOS

  • updateweb/ topublic/

Cheers!

Koc reacted with hooray emoji
@weaverryan
Copy link
MemberAuthor

This is now ready! I hope to release the library on Monday. And so, this code is not easily testable yet (it requires a dev version of Encore, using an unreleased bundle and using a WIP recipe), but the content is ready for review.

Thanks!

@weaverryanweaverryan merged commit12ca7d9 intosymfony:3.4Nov 5, 2018
weaverryan added a commit that referenced this pull requestNov 5, 2018
This PR was squashed before being merged into the 3.4 branch (closes#10322).Discussion----------[WCM] Encore updates for Webpack 4Phew! The next (unreleased) version of Webpack Encore (will be 0.21.0) that supports Webpack 4 will contain a few minor changes, that have major implications on the documentation. Ultimately, I think the experience will be easier for users :). The 3 big changes are:1) In all cases, people should use the new WebpackEncoreBundle and its 2 new Twig functions - `encore_entry_script_tags()` and `encore_entry_link_tags()` to render their `script` and `link` tags.2) In earlier versions, an extra `manifest.js` file was output when using `createdSharedEntry()`. But now, a new `runtime.js` file is *always* output. But, because of the `encore_entry_script_tags()` shortcut... that's just rendered for you automatically.3) `createSharedEntry()` is no longer hipster ;). This is from changes in Webpack. A newer, and better "split chunks" feature replaces it... which (other than changing how existing users think), is much simpler. Basically, the user does nothing... except call `encore_entry_script_tags()`. But, when this feature is enabled, the final `.js` and `.css` files may be split into multiple files. And so, the `encore_entry_script_tags()` (and also the link version) may render *multiple* script tags. This all happens automatically.TODO: Wait for the bundle to be tagged, then test the new recipe (symfony/recipes#458) and code through some of the docs to catch any mistakes (due to so many changes).**Merging into 4.1 TODOS*** update `web/` to `public/`Cheers!Commits-------12ca7d9 adding a small entry about ajax code splitting165432f fixing build errorsbf649ab Documenting copyFiles() and a few small things6833bb6 finishing read-throughc2b36a2 more work on encore53f9ffe Adding docs for runtime.js and fixed a few other things62f322e documenting the new split chunks and Twig helper functions for Encore
@weaverryanweaverryan deleted the encore-webpack4 branchNovember 5, 2018 19:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weaverryan@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp