Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Routing] Update routing.rst, add example routes as annotations#10201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
javiereguiluz merged 2 commits intosymfony:4.3fromandreybolonin:patch-4
Aug 12, 2019
Merged

[Routing] Update routing.rst, add example routes as annotations#10201

javiereguiluz merged 2 commits intosymfony:4.3fromandreybolonin:patch-4
Aug 12, 2019

Conversation

@andreybolonin
Copy link
Contributor

No description provided.

@andreyboloninandreybolonin changed the titleUpdate routing.rst, add example routes as annotations[Routing] Update routing.rst, add example routes as annotationsAug 20, 2018
@weaverryan
Copy link
Member

Hey@andreybolonin!

Thanks for the PR to add more details :). I just updated a few parts of the code to useuse statements, for example. But, there is one problem left: the code uses a class from FrameworkBundle -AnnotatedRouteControllerLoader. But, we can't do that: because this code is about setting up the Routing component in a standalone project, we can only use classes from other components.

Could you update the code to not use this class? It's actually a bit odd, I see why you usedAnnotatedRouteControllerLoader... it does some nice things with setting the_controller. I'm not actually sure if thereis a feasible way ofnot using this class. That's what we need to check out.

Status: Needs work

@javiereguiluz
Copy link
Member

@weaverryan I think it's really difficult to not useAnnotatedRouteControllerLoader in this example ... unless we copy+paste the code fromAnnotatedRouteControllerLoader ... is it worth it?

andreybolonin reacted with thumbs up emoji

@javiereguiluz
Copy link
Member

Another solution would be to not useAnnotatedRouteControllerLoader ... but then, which format should use the PHP classes to define annotations on them? What's the difference when not usingAnnotatedRouteControllerLoader? This is the component doc, so I guess is OK to not provide all features included in the full Symfony framework.

@xabbuhxabbuh added this to the3.4 milestoneMar 8, 2019
@javiereguiluzjaviereguiluz modified the milestones:3.4,4.3Aug 12, 2019
@javiereguiluzjaviereguiluz changed the base branch from4.1 to4.3August 12, 2019 11:29
@javiereguiluz
Copy link
Member

Andrey, we're sorry for not having merged this until today. We finally did. We decided to keep the example with the AnnotatedRouteControllerLoader because the docs about Symfony components are read by advanced developers and they'll know what to do (install the dependency or copy code from it). Thanks!

andreybolonin reacted with thumbs up emoji

@javiereguiluzjaviereguiluz merged commit54743d6 intosymfony:4.3Aug 12, 2019
javiereguiluz added a commit that referenced this pull requestAug 12, 2019
…tations (andreybolonin, weaverryan)This PR was submitted for the 4.1 branch but it was merged into the 4.3 branch instead (closes#10201).Discussion----------[Routing] Update routing.rst, add example routes as annotations<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/roadmap for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `master` for features of unreleased versions).-->Commits-------54743d6 cleaning up some use statements, etc0a1badf Update routing.rst
@andreybolonin
Copy link
ContributorAuthor

@javiereguiluz thx

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@andreybolonin@weaverryan@javiereguiluz@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp