Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Validator] Document the DivisibleBy constraint#10121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
javiereguiluz merged 1 commit intosymfony:masterfromcolinodell:feature/multiple-of-validatorSep 6, 2018
Merged
[Validator] Document the DivisibleBy constraint#10121
javiereguiluz merged 1 commit intosymfony:masterfromcolinodell:feature/multiple-of-validatorSep 6, 2018
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
OskarStark approved these changesJul 26, 2018
ContributorAuthor
colinodell commentedAug 10, 2018
The constraint has been renamed, so I've updated the documentation accordingly. |
OskarStark approved these changesAug 10, 2018
symfony-splitter pushed a commit to symfony/validator that referenced this pull requestAug 15, 2018
…ivisibility (colinodell)This PR was squashed before being merged into the 4.2-dev branch (closes #28069).Discussion----------[Validator] New `DivisibleBy` constraint for testing divisibilityThis introduces a new ~`MultipleOf`~ `DivisibleBy` constraint which checks whether one number is a multiple of (aka "divisible by") some other number. Useful for enforcing specific increments on a number.| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR |symfony/symfony-docs#10121Seesymfony/symfony-docs#10121 for examples of this constraint in action.Commits-------efcfb8b22d [Validator] New `DivisibleBy` constraint for testing divisibility
nicolas-grekas added a commit to symfony/symfony that referenced this pull requestAug 15, 2018
…ivisibility (colinodell)This PR was squashed before being merged into the 4.2-dev branch (closes#28069).Discussion----------[Validator] New `DivisibleBy` constraint for testing divisibilityThis introduces a new ~`MultipleOf`~ `DivisibleBy` constraint which checks whether one number is a multiple of (aka "divisible by") some other number. Useful for enforcing specific increments on a number.| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR |symfony/symfony-docs#10121Seesymfony/symfony-docs#10121 for examples of this constraint in action.Commits-------efcfb8b [Validator] New `DivisibleBy` constraint for testing divisibility
javiereguiluz approved these changesSep 4, 2018
Member
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@colinodell thanks a lot for providing this new constraint and for documenting it too. Sadly there are some merge conflicts. Could you please fix them? Thanks!
ContributorAuthor
colinodell commentedSep 4, 2018
Thanks for the heads-up@javiereguiluz! Looks like the |
Member
javiereguiluz commentedSep 6, 2018
It's merged now. Thanks Colin! |
javiereguiluz added a commit that referenced this pull requestSep 6, 2018
…ell)This PR was merged into the master branch.Discussion----------[Validator] Document the DivisibleBy constraintDocumentation for the new ~`MultipleOf`~ `DivisibleBy` constraint proposed insymfony/symfony#28069Commits-------3270cca Document the DivisibleBy constraint
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Documentation for the new
MultipleOfDivisibleByconstraint proposed insymfony/symfony#28069