Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Routing] Add locale fallback to internationalized routes#10108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Routing] Add locale fallback to internationalized routes#10108
Uh oh!
There was an error while loading.Please reload this page.
Conversation
32051bd toc15df9dComparerouting.rst Outdated
| ..tip:: | ||
| If you use full locales (language + territory) in your application (e.g. `fr_FR`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
s/territory/culture/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure about this, I took it from Wikipedia and the info seems to come from the ISO standard (https://en.wikipedia.org/wiki/Locale_(computer_software)).
| for several full locales that share the same language (e.g. `fr_FR` and `fr_BE`). | ||
| ..versionadded::4.2 | ||
| The feature to fall back on the language part only was introduced in Symfony 4.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fallback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think "fallback" is the noun, and "fall back" the verb (https://english.stackexchange.com/questions/90549/difference-between-fallback-and-fall-back)
nicolas-grekas commentedAug 10, 2018
upstream merged |
1 similar comment
nicolas-grekas commentedAug 10, 2018
upstream merged |
…nationalized routes (fancyweb)This PR was merged into the 4.2-dev branch.Discussion----------[Routing] Add fallback to cultureless locale for internationalized routes| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |symfony/symfony#27938| License | MIT| Doc PR |symfony/symfony-docs#10108Please check the related issue for the context.TODO :- [x] Update CHANGELOG- [x] Update documentationCommits-------fd2e3c36fb [Routing] Add fallback to cultureless locale for internationalized routes
…nationalized routes (fancyweb)This PR was merged into the 4.2-dev branch.Discussion----------[Routing] Add fallback to cultureless locale for internationalized routes| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#27938| License | MIT| Doc PR |symfony/symfony-docs#10108Please check the related issue for the context.TODO :- [x] Update CHANGELOG- [x] Update documentationCommits-------fd2e3c3 [Routing] Add fallback to cultureless locale for internationalized routes
javiereguiluz commentedSep 4, 2018
@fancyweb this is a truly convenient feature! Love it. Thanks for contributing it. |
…s (Thomas Calvet, javiereguiluz)This PR was merged into the master branch.Discussion----------[Routing] Add locale fallback to internationalized routesRelated PR :symfony/symfony#27957Commits-------02cc739 Minor rewordc15df9d [Routing] Add locale fallback to internationalized routes
Related PR :symfony/symfony#27957