method name is 'index' not 'indexAction'#10046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

dcsmith926 wants to merge1 commit intosymfony:4.1fromdcsmith926:patch-1

Closed

method name is 'index' not 'indexAction'#10046

dcsmith926 wants to merge1 commit intosymfony:4.1fromdcsmith926:patch-1

Conversation

Copy link

Contributor

dcsmith926 commentedJul 11, 2018

The route definitions here reference a methodindexAction on theLeapYearController but the method is defined asindex.

method name is 'index' not 'indexAction'

1935fb1

The route definitions here reference a method `indexAction` on the `LeapYearController` but the method is defined as `index`

carsonbot added the Status: Needs Review label

Jul 11, 2018

javiereguiluz added Status: Reviewed and removed Status: Needs Review labels

Jul 11, 2018

javiereguiluz added this to the4.0 milestone

Jul 11, 2018

Copy link

Member

javiereguiluz commentedJul 11, 2018

@dcsmith926 super nice catch! Thanks for fixing it. We merged it in 4.0 (the oldest maintained branch where this bug fix applies) and later we'll merge automatically in the upper branches. Congrats on your first Symfony Docs contribution!

javiereguiluz added a commit that referenced this pull request

Jul 11, 2018

minor#10046method name is 'index' not 'indexAction' (dcsmith926)

4ea2865

This PR was submitted for the 4.1 branch but it was merged into the 4.0 branch instead (closes#10046).Discussion----------method name is 'index' not 'indexAction'The route definitions here reference a method `indexAction` on the `LeapYearController` but the method is defined as `index`.Commits-------d92599a method name is 'index' not 'indexAction'

javiereguiluz closed this

Jul 11, 2018