Commitf7adcfa

committed

minor#6228 removed unnecessary exception from repository (gondo)

This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes#6228).Discussion----------removed unnecessary exception from repositoryremoved `UsernameNotFoundException` form repository as this logic does not belong to repository and also it is duplicated. exception is already thrown on proper place if no user is found:https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/Security/User/EntityUserProvider.php#L60Commits-------0e288a2 removed unnecesary exception form repository

2 parentsab57eed +0e288a2 commitf7adcfaCopy full SHA for f7adcfa

File tree

1 file changed

-12

lines changed

cookbook/security
- entity_provider.rst

1 file changed

-12

lines changed

`‎cookbook/security/entity_provider.rst‎`

Lines changed: 1 addition & 12 deletions

Original file line number	Diff line number	Diff line change
@@ -432,29 +432,18 @@ interface only requires one method: ``loadUserByUsername($username)``::
`432`	`432`
`433`	`433`	`use Symfony\Bridge\Doctrine\Security\User\UserLoaderInterface;`
`434`	`434`	`use Symfony\Component\Security\Core\User\UserInterface;`
`435`		`- use Symfony\Component\Security\Core\Exception\UsernameNotFoundException;`
`436`	`435`	`use Doctrine\ORM\EntityRepository;`
`437`	`436`
`438`	`437`	`class UserRepository extends EntityRepository implements UserLoaderInterface`
`439`	`438`	`{`
`440`	`439`	`public function loadUserByUsername($username)`
`441`	`440`	`{`
`442`		`-$user = $this->createQueryBuilder('u')`
	`441`	`+return $this->createQueryBuilder('u')`
`443`	`442`	`->where('u.username = :username OR u.email = :email')`
`444`	`443`	`->setParameter('username', $username)`
`445`	`444`	`->setParameter('email', $username)`
`446`	`445`	`->getQuery()`
`447`	`446`	`->getOneOrNullResult();`
`448`		`-`
`449`		`- if (null === $user) {`
`450`		`- $message = sprintf(`
`451`		`- 'Unable to find an active admin AppBundle:User object identified by "%s".',`
`452`		`- $username`
`453`		`- );`
`454`		`- throw new UsernameNotFoundException($message);`
`455`		`- }`
`456`		`-`
`457`		`- return $user;`
`458`	`447`	`}`
`459`	`448`	`}`
`460`	`449`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitf7adcfa

File tree

1 file changed

1 file changed

`‎cookbook/security/entity_provider.rst‎`

0 commit comments