Commiteb637f0

committed

minor#9179 uploading example: explaining the need for md5 (MacDada, javiereguiluz)

This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes#9179).Discussion----------uploading example: explaining the need for md5Plus extracted function with a name that makes the comment unnecessary.Commits-------9321577 Reword a code comment6185887 uploading example: explaining the need for md5

2 parents48cd7f8 +9321577 commiteb637f0Copy full SHA for eb637f0

File tree

1 file changed

+11

-2

lines changed

controller
- upload_file.rst

1 file changed

+11

-2

lines changed

`‎controller/upload_file.rst`

Lines changed: 11 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -136,8 +136,7 @@ Finally, you need to update the code of the controller that handles the form::`
`136`	`136`	`/** @var Symfony\Component\HttpFoundation\File\UploadedFile $file */`
`137`	`137`	`$file = $product->getBrochure();`
`138`	`138`
`139`		`- // Generate a unique name for the file before saving it`
`140`		`- $fileName = md5(uniqid()).'.'.$file->guessExtension();`
	`139`	`+ $fileName = $this->generateUniqueFileName().'.'.$file->guessExtension();`
`141`	`140`
`142`	`141`	`// Move the file to the directory where brochures are stored`
`143`	`142`	`$file->move(`
`@@ -158,6 +157,16 @@ Finally, you need to update the code of the controller that handles the form::`
`158`	`157`	`'form' => $form->createView(),`
`159`	`158`	`));`
`160`	`159`	`}`
	`160`	`+`
	`161`	`+ /**`
	`162`	`+ * @return string`
	`163`	`+ */`
	`164`	`+ private function generateUniqueFileName()`
	`165`	`+ {`
	`166`	`+ // md5() reduces the similarity of the file names generated by`
	`167`	`+ // uniqid(), which is based on timestamps`
	`168`	`+ return md5(uniqid());`
	`169`	`+ }`
`161`	`170`	`}`
`162`	`171`
`163`	`172`	Now, create the ``brochures_directory`` parameter that was used in the

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commiteb637f0

File tree

1 file changed

1 file changed

`‎controller/upload_file.rst`

0 commit comments